Form says “success” although no api connection
-
I just update to version 2.3.0 – thank you for the recent update and adding the long missed “refresh_token”.
After updating I reloaded my subscription form and put my Email address in it, and the form said “success” – while it should have said “address already registered”.
Then I saw in the backend that the Api connection was reset after the update, it now tells me to reconnect with CleverReach.
It says:
“Stellen Sie eine erneute Verbindung mit der neuen CleverReach API her. CleverReach hat die API geändert. Bitte verbinden Sie Ihren Account hier erneut mit der neuen REST API und überprüfen Sie alle Ihre Einstellungen.”
So the situation is:
– I have no Api connection
– but the form validates to “1”I think the problem lies in “class-form.php”, maybe there should be some kind of check wether there is an active connection to the API in the function process_form() ?
There is this line:
if ( $validation->valid && $this->auth_service->get_access_token() ) {
but if there is no access_token available then nothing happens.
Maybe that case is a rare situation, but in times of WordPress auto updating itself (and plugins) it’s not unlikely that you get an update and nobody is there to check it immediately.
-
Hi Dennis,
thank you for your reply but I think you didn’t understand the problem.
- old version 2.2. was installed, this version was managing “access_token” and such totally different
- Plugin was updated to 2.3.0, “everything” (under the hood) was changed
- as one result connection to Api was lost
- but still the form in the frontend rendered “Success” – no matter the user was already signed up or not – and although nothing actually “happened”, because there was no connection to CleverReach / the api
This I consider as a bug or flaw, because this is bad when you are on “Auto update”.
As I wrote above, I think the reason lies in class-form.php in function process_form().
It sets “$validation->valid” to true by default, and when there is something wrong with the Api connection or when there is no access_token “$validation->valid” remains true … and the form shows “success”.
In line 108 the validation has this statement:
if ( $validation->valid && $this->auth_service->get_access_token() ) { ... }$this->auth_service->get_access_token() just reads the access_token from the database – which was not there.
And when $validation->valid is true, but $this->auth_service->get_access_token() is false, then the code in the if-statement is not executed (which is ok), but $validation->valid remains true.
Maybe you can forward this to your developer(s), they might have a better understanding?
Viele Grüße!
- The topic ‘Form says “success” although no api connection’ is closed to new replies.
