WordPress.org

Forums

WP Facebook Open Graph protocol
[resolved] Footer html added to feed with 2.0.7 (19 posts)

  1. I saw this topic addressed in an earlier post, but the OP deactivated the plugin before any solution was discussed. I've found that the output buffering is causing the extra footer html to be added to the top of the feed.

    I had to update a couple of functions in wp-facebook-ogp.php to resolve this:

    function wpfbogp_start_ob() {
    	// Start the buffer before any output
    	if ( ! is_feed() ) {
    		ob_start( 'wpfbogp_callback' );
    	}
    }

    and

    function wpfbogp_flush_ob() {
    	if ( ! is_feed() ) {
    		ob_end_flush();
    	}
    }

    I also installed the 2.1 dev version and that has fixed the problem!

    http://wordpress.org/plugins/wp-facebook-open-graph-protocol/

  2. Chuck Reynolds
    Member
    Plugin Author

    Posted 1 year ago #

    So let me ask... this hack you put on 2.0.7 and that worked...
    did you also have to hack 2.1 in order to fix the issue or is 2.1 already not causing the problem?
    Just want to make sure I understand your message :)

  3. 2.1 is fine. As I recall 2.1 doesn't even use the output buffering, which seems to be causing the issue with 2.0.7.

  4. Chuck Reynolds
    Member
    Plugin Author

    Posted 1 year ago #

    right.. i just wanted to make sure that was the problem.

    Thanks for your digging man. appreciate it.

  5. No problem, and definitely my pleasure.

    When I help folks on the WordPress.org support forums, I not only try to help the user get their site working again, but I also try to help make WordPress better by passing on any discoveries to theme/plugin authors, especially if the original poster can't or won't submit a bug report themselves.

    Thanks!

  6. Chuck Reynolds
    Member
    Plugin Author

    Posted 1 year ago #

    And that's how it should be!! :)
    now ... just for me to get some free time to actually finish testing 2.1 changes and push the huge update to the repo. all on github just no time.

  7. lagerkoller
    Member
    Posted 1 year ago #

    whooooah,
    what a nightmare. lost 2 hours figuring out why my feed was broken. turned out i've had just the same problem mentioned above with html output over the xml declaration. scriptrunner's hack fixed my problems.

    i think this hack would be worth a (quick) version 2.0.8…

    thanks.

  8. Chuck Reynolds
    Member
    Plugin Author

    Posted 1 year ago #

    pushed 2.2 which fixes

  9. lagerkoller
    Member
    Posted 1 year ago #

    hi,
    updated to the newest version (2.2). broke my site, only background was visible. deactivate plugin for now. got a lot of work to do. will maybe try to locate the cause for the problem later.

  10. Chuck Reynolds
    Member
    Plugin Author

    Posted 1 year ago #

    cache? you have debug on? be nice to know the environment a bit.

  11. lagerkoller
    Member
    Posted 1 year ago #

    hi,
    no cache. no debugging so far. enabled debug to see if something is logged, nothing open graph plugin related appeared in the logs.

    if you like to have a look at it, i will keep the plugin enabled for the next ten minutes: johannesluderschmidt.de

  12. Chuck Reynolds
    Member
    Plugin Author

    Posted 1 year ago #

    nah. i'm tired. i reverted the repo. something's weird with only certain builds. idk if it's a php version issue? all 5 of my test sites worked fine except one... white screened admin and frontend. idk man. I'm gonna get some help on it... just so busy at work lately.

  13. lagerkoller
    Member
    Posted 1 year ago #

    alright. thanks anyway!

  14. Chuck Reynolds
    Member
    Plugin Author

    Posted 1 year ago #

    and the one crashed site is back... i did nothing to bring it back. ? lol. ugh.

  15. Chuck Reynolds
    Member
    Plugin Author

    Posted 1 year ago #

    Hey lagerkoller... what version of PHP are you on?

  16. Chuck Reynolds
    Member
    Plugin Author

    Posted 1 year ago #

    on all my php 5.3x servers I can't find a problem

  17. Chuck Reynolds
    Member
    Plugin Author

    Posted 1 year ago #

    just pushed v2.0.8
    Fixes the feed issues some ppl are seeing
    Fixes media uploader link
    Fixes html namespace to prefix from xmlns

  18. lagerkoller
    Member
    Posted 1 year ago #

    mmh, i am using php 5.3.2. so that should not be an issue…

    thanks for the 2.0.8 update. everything is working like a charm :)

  19. Chuck Reynolds
    Member
    Plugin Author

    Posted 1 year ago #

    nope. that's not the issue then obviously. no clue. would you maybe put the 2.1dev test version on with debug on and see if you can't see any problems?

    yw for 2.0.8. i had to clean a lot up in my dev environment to extract the old stuff back out. glad it works well.

Topic Closed

This topic has been closed to new replies.

About this Plugin

  • WP Facebook Open Graph protocol
  • Frequently Asked Questions
  • Support Threads
  • Reviews

About this Topic

Tags

No tags yet.