I took a look through the patch and appreciate you're taking the time to write it up and report it! Your attention to detail really helps out others a lot.
Notice & patch
I think I saw the notice you were referring to, but want to make sure the change I committed resolves the issue for you, so please check version 1.1.1 that was just deployed.
From what I could see in the error, the notice was being caused by PHP's
parse_url was not returning a
path value for sites that were installed in the root directory. Rather than change where the plugin inits, I took the route of suppressing notices for that var, knowing it may or may not be in the array.
__CLASS__ vs. Class_Name::
While I can understand some advantages of using
__CLASS__ to reference the current static class name (especially if the class is renamed), I prefer the
Class_Name:: syntax to help give context while reading through the method.
Since this seemed to be more a matter of style preference than directly related to the notice, I left that change out. Please let me know if I missed a significant functional difference here, or if I'm not addressing the actual error you were!
Thanks & credit
Thanks for the excellent work! I have credited you and referenced this thread in the changelog.