Fixed some bug…

Resolved Anonymous User 357386
(@anonymized-357386)

7 years, 5 months ago
http://pastebin.com/53sJD4MF

(more error in source view – firefox – cause bad code formatting, now fixed).

here with search bar also for guest: http://pastebin.com/0GH1dYKU
also, i’ve change offset on-click (by js) to 60px (caus bad view if adminbar is active)…

maybe some little settings for this (search bar and offset) can be a good idea!

ah, what is the little arrow left to print button?

line 3088… click on this button and nothing happen 😐
```
echo "<a class='quotes-llama-quote-author-back quotes-llama-inline' title='" . esc_html__( 'Return to' ) . ' ' . $this->strip_trim_wp_kses_post( $author ) . "' href='#" . $author . "'><input type='button' value='&larr;'></a>";
echo "<input type='button' value='Print' class='quotes-llama-print')"; ?>
```
and, see now, also an error in line 3088:
echo "<input type='button' value='Print' class='quotes-llama-print')"; ?>
instead of:
echo "<input type='button' value='Print' class='quotes-llama-print'>"; ?>
- This topic was modified 7 years, 5 months ago by Anonymous User 357386.
- This topic was modified 7 years, 5 months ago by Anonymous User 357386.

Viewing 15 replies - 1 through 15 (of 26 total)

1 2 →

Thread Starter Anonymous User 357386
(@anonymized-357386)

7 years, 5 months ago

I’ve found another issue…
in list, if i put more quotes with images, only first quote can show image (and – atm – i cannot found a valid way to fox) :/

Thread Starter Anonymous User 357386
(@anonymized-357386)

7 years, 5 months ago

ok, fixed all!
https://laltroweb.it/_dev/citazioni/

please, reply if i can share and help 🙂

Plugin Author oooorgle
(@oooorgle)

7 years, 5 months ago

Hey yes! Sorry, been working lots with Winter coming. I will hopefully get on this by the weekend at latest. You are awesome!

Thread Starter Anonymous User 357386
(@anonymized-357386)

7 years, 5 months ago

thanks 🙂
i’ve also insert a fix in *.js for print release.
now image remain to 150px x 150px!

if u glad, i can send a link with entire pack + mycustom_css and u can analyze.

Plugin Author oooorgle
(@oooorgle)

7 years, 5 months ago

Yes, please do send them.

Thread Starter Anonymous User 357386
(@anonymized-357386)

7 years, 5 months ago

> https://laltroweb.it/_dev/quotes-llama_fix.zip

please, note, this contain more customization (like search bar enabled for guest – but with image search filter removed because, imho, isn’t more useful…)

also some css like pencil for author and little arrow in source!
anyway, imho all work as expected (except lang – ill try to start an ita translation (u can find in pack) but remain in english).

anyway, with a simple compare u can see without problem all difference (especially in quotes-llama.php and in css).

kind regards,
S.N.
Plugin Author oooorgle
(@oooorgle)

7 years, 5 months ago
In progress… and if I may ask; is there a reason that <small><em> is better to use than <cite>? I don’t have much of a preference myself and was just wondering.
- This reply was modified 7 years, 5 months ago by oooorgle.
- This reply was modified 7 years, 5 months ago by oooorgle.
- This reply was modified 7 years, 5 months ago by oooorgle.
- This reply was modified 7 years, 5 months ago by oooorgle.
- This reply was modified 7 years, 5 months ago by oooorgle.
Plugin Author oooorgle
(@oooorgle)

7 years, 5 months ago
You’ve made some really great improvements. Especially fixing the page print and back buttons, href linking etc, etc. I do have a couple more questions as I proceed.

1) The Javascript documents refer to unescape() as being depricated and to use URIdecode instead. Is unescape() a better method to go about it?
http://www.w3schools.com/jsref/jsref_unescape.asp

2) The Genericon set isn’t included with WordPress. Alternatively, there is the dashicons set which can be made available on the front-end with a simple enqueue.
wp_enqueue_style( "dashicons-style", get_stylesheet_uri(), array( "dashicons" ), "1.0" );
css:
content: "\f540";
font-family: "dashicons";

What do you think about that as an option for implementing a consistent icon set? Though, the closest icon I see to the pencil is the paintbrush. (…correction, there is a pencil \f464 :))
http://developer.wordpress.org/resource/dashicons
- This reply was modified 7 years, 5 months ago by oooorgle.
- This reply was modified 7 years, 5 months ago by oooorgle.
Thread Starter Anonymous User 357386
(@anonymized-357386)

7 years, 5 months ago

small-em vs cite: no, is simply a “less important data”…
then, imho, is best to put a small font 🙂

i don’t remember to have edit any unescape function, sorry 😐

Genericons is included in my twentysixteen default wordpress theme – then, i’ve think is included in all! another possibility can be to use simply: eg > http://emojipedia.org/emoji/%F0%9F%93%9D/
aniway, dashicon seems to be a good idea 🙂
Plugin Author oooorgle
(@oooorgle)

7 years, 5 months ago
Interesting that WordPress packages the Genericons with the theme and not the core, dashicons it is.

I notice you have a different image for each quote on your site. I use the same image for per author in mine. That is why I had it only show the first instance of the image.

Perhaps having the image show only once and then repeat again when it changes to another image? With each of your quotes having its own image, you wouldn’t (shouldn’t) notice any difference and I would still get the result I am seeking. What do you think?

Here is an example: This changes the template_page_search() and template_page_author() functions. I then assume you would need to duplicate some images for an author, to see them omitted in the page. I needed to create some unique images to test mine and it seems to work well. Thanks!!!
http://pastebin.com/JyedigrG
- This reply was modified 7 years, 5 months ago by oooorgle.
Thread Starter Anonymous User 357386
(@anonymized-357386)

7 years, 5 months ago

I’ve put image one by one because I seen image field for every quote and when inserted no image present in list (except one – the first).
Indeed, put just one per author can bee a good/clean idea 🙂
–
I don’t have tested your paste in atm (I’m by mobile…).
I think can be a bit complicated!

What if inside an author list with 20 quotes we have just 2of them with images?
Then, imho, u need to choose if u prefers “just one (author) image” for entire list and remove image setting field from quotes list, and put author image setting in new tab.
Or image for every quote (maybe with default image if no image is present).

But this is just my opinion!
If u find best solution – obviously – is ok 🙂

Plugin Author oooorgle
(@oooorgle)

7 years, 4 months ago

Version 0.6 uploaded! There were a lot of changes so I hope I got it right. Added some new options, including it has an option to use ‘<br>’ instead of a comma to separate the author/source. But, anyways please feel free to let me know what else is IYHO, and thanks tons for so much work on this plugin!

I added to the to-do of how to make direct links and perhaps rss for the quotes as you mentioned in your review. Yet another great idea I’d not had myself. 🙂
Thread Starter Anonymous User 357386
(@anonymized-357386)

7 years, 4 months ago
all seems to be perfect, great work 🙂

just a little clean-fix:
```
<span class=”quotes-llama-widget-next” divid=”q34924″ author=”1″ source=”1″ img=”1″>
<i>
… (next quote)
</i>
```
in css:
```
.quotes-llama-widget-next {
    display: block;
    font-size: 0.8em;
    font-style: italic;
    text-align: right;
}
```
if u put <i></i> (or em) inside quotes-llama-widget-next isn’t necessary to use italic in css 😉

anyway, all seems to work perfect, thank’u (alsdo for credit in changelog – really appreciated) 🙂
- This reply was modified 7 years, 4 months ago by Anonymous User 357386.
Thread Starter Anonymous User 357386
(@anonymized-357386)

7 years, 4 months ago

ps: also lang file continue to not work – i cannot understood why, sorry 😐

Plugin Author oooorgle
(@oooorgle)

7 years, 4 months ago

Removed the <i> in preference of css and fixed another issue in ver 0.6.1. Going to work on the translations, I cannot get mine working either.

Cheers!

Viewing 15 replies - 1 through 15 (of 26 total)

1 2 →

The topic ‘Fixed some bug…’ is closed to new replies.