FIX: ERROR: Please enter your password. on new manual user creation

Hey there. After moving to php 5.5.9, I was getting an error every time a new user was created (we have auto user creation turned off). it was ERROR: Please enter your password.

Looking in wp-admin/includes/user.php, line 111:

/* checking the password has been typed twice */
	/**
	 * Fires before the password and confirm password fields are checked for congruity.
	 *
	 * @since 1.5.1
	 *
	 * @param string $user_login The username.
	 * @param string &$pass1     The password, passed by reference.
	 * @param string &$pass2     The confirmed password, passed by reference.
	 */

ADI code on ad-integration.php line 970:

public function generate_password($username, $password1, $password2) {
		$password1 = $password2 = $this->_get_password();
	}

My change:

public function generate_password($username, &$password1, &$password2) {
		$password1 = $password2 = $this->_get_password();
	}

I’m just passing the passwords in by reference as wordpress is requesting. I’m guessing PHP 5.3 was more lax about that? I found that the passwords were empty until I passed by reference. Let me know if this helps.

https://wordpress.org/plugins/active-directory-integration/