Hello Namita,
No problem.
Couple of questions …
- Twenty Nineteen doesn’t have a fly-out sub-sub menu … it just puts a dash next to the sub-sub menu items. Do you still require the ability to change font size for these menu items?
- Twenty Nineteen considers mobile (small screen) to be a width less than 768px and tablet (medium screen) to be a width less than 1168px. Usually we don’t add separate controls for each screen size but instead replicate the ratios that the theme would use for the different breakpoints for a single given font size control. However Twenty Nineteen doesn’t set a different font size for these different breakpoints so we suggest that a single control is used for font size and then two global controls are set to control the ratio of the small / medium screens based on this value? This would prevent the requirement for multiple controls for each element going forward.
Line Height is based as a multiple of the font size so you wouldn’t need to control the line height for different screen sizes, just set it right for one and the others would adjust accordingly.
Oliver
Thread Starter
Namita
(@namitanl)
Hi Oliver,
Thanks for your prompt reply.
1. Yes it would be nice to have the Sub (and or sub-sub) menu differentiate with font-size, bold vs italic text for instance. I noticed that Firefox on desktop doesn’t even show the dash, so it would be nice if I could make the sub category bold and the sub-sub category Italic for instance.
2. Yes, I agree with your suggestion.
And thanks for the explanation.
Regards,
Namita
OK, no problem, we’ll get this done and let you know as soon as it has been done.
Oliver
Thread Starter
Namita
(@namitanl)
Thanks Oliver, keep me posted.
Hi,
Just pushed a new version of the plugin with the following additional options …
“Customizer – General Options – Mobile Font Size”
“Customizer – General Options – Tablet Font Size”
“Customizer – Nav Options – Sub Nav Font Size”
“Customizer – Nav Options – Sub Sub Nav Font Size”
Hope that works for you.
Oliver
Thread Starter
Namita
(@namitanl)
Thanks Oliver, I can see the new sliders under “Navigation Font Size”, “Sub Nav Font Size”, “Sub Sub Nav Font Size”.
I can only manipulate the original “Navigation Font Size” but not “Sub Nav Font Size”, “Sub Sub Nav Font Size”. Also there is no difference for desktop, tablet and mobile view.
I tried Firefox and Chrome.
If I am the only one having this problem I can check somewhere during the weekend if it is caused by the fact that I might have moved the menu in an earlier stage.
But the “Navigation Font Size” works, so it would be logical that it would work on the children as well.
“Customizer – General Options – Mobile Font Size”
“Customizer – General Options – Tablet Font Size”
Firstly, please make sure you are using these controls to set the difference in font sizes for mobile and tablet.
“Customizer – Nav Options – Sub Nav Font Size”
“Customizer – Nav Options – Sub Sub Nav Font Size”
Secondly, please set values for these two settings and click publish so I can check your https://www.namita.nl/ site to see what’s going on.
Many thanks,
Oliver
Thread Starter
Namita
(@namitanl)
I went back. Altered the font-sizes under general options-> Published
Went to Nav options -Changed font-sizes-> Published.
(Cleared the cache in WP)
Not seeing the changes in the Sub and SUB SUB Nav menus. I will check it again tomorrow, maybe I missed something obvious.
Thanks for your time, there is no rush, really appreciate you looking into this.
Regards,
Namita
Hi,
OK, we. can see the problem. We assumed that “menu-primary-container” was the classname for the theme’s primary menu container. It isn’t, it’s the classname for the menu that you use so we’ll get that fixed and let you know when we’ve released a patch.
Sorry about that!
Oliver
Hi,
Just to confirm that we have pushed an update to fix this bug now.
Please confirm.
Oliver
Thread Starter
Namita
(@namitanl)
Thank you so much Oliver! I just needed to update the plugin to see the changes!
Works like a charm 🙂
That’s great news. Thanks for letting me know.
Oliver
