Support » Plugin: String locator » Feature idea, search a repo.

  • Hi Marius, I wanted to submit a pull request but I noticed that the GitHub repo is n’t up to date. Is there any other than this one?

    The idea of my PR is to add a filter for $bad_file_types.

    Thank you for your time and work 馃槈

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Marius L. J.

    (@clorith)

    Hiya,

    I must admit, I am terrible at keeping my GitHub mirror up to date 馃檨

    That is a great idea though, it’s definitely a situation where a filter makes perfect sense and I’ll be sure to introduce one.

    Thanks, it would be nice to also have a filter for the Codemirror parameters. For example to switch to read-only.

    Have a day.

    Plugin Author Marius L. J.

    (@clorith)

    Hiya,

    Sorry for the delay in giving some more feedback here, but the next version wasn’t going to come until WordPress 4.9 so it passed me by for a while.

    The new filter in question will be introduced with the next version of the plugin (2.3.0), which will be released right after WordPress 4.9, this is to use the version of CodeMirror now bundled in core.

    As for filtering the CodeMirror parameters, this would also be made possible now, using the core filters introduced alongside the editor, you can read more about it at https://make.wordpress.org/core/2017/10/22/code-editing-improvements-in-wordpress-4-9/ if it’s of interest to you 馃檪

    And I’ll be pushing the updates to the GitHub repository as well when the update goes live so it should be back in sync again 馃檪

    Hey, great news.

    When I saw that the 4.9 will use mirror code, I suspected that you would remove the external dependency.

    Perfect for Github, I could do PR next time 馃槈

    Thanks

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Feature idea, search a repo.’ is closed to new replies.