Feature: Clarify Sale End Dates + Maybe Change Behavior

I pretty frequently forget whether the sale end date for a product means the sale runs until that date, or through it. I believe the current behavior is that it runs through it. This interpretation makes the most sense, probably, in English when you call it the “Sale end date” and think of how we normally talk about events in, at least, the United States. But I really think we should clarify this by adding some words like “Date sale ends after” or have a little ‘?’ circle that reads “The sale ends after 23:59 on this date.” on hover.

I think the reason we get confused is because it runs contrary to most programmer/mathematician logic to do it this way. Wouldn’t it usually be programmed more like IF (START <= TODAY & END > TODAY)? That might seem arbitrary (why not >= ?), but this tends to even more questions when I think about this in terms of data: If I import products with a sale end date of 2099-12-31 23:59:59, is the hms part preserved in the WP database, or does it get saved as 2099-12-31? If it is saved as 2099-12-31 without the hms, would it not make sense that this translated in data conversion to 2099-12-31 00:00:00? It is more reasonable to me with my background to change it so that the sale runs UNTIL the end date, not through it. This of course, is an important change, and backwards compatibility along with user awareness are important.

Either way, there needs to be more clarification about EXACTLY what happens when we set, import, or export the sale schedules.

• This topic was modified 2 years, 7 months ago by CubicInfinity.