Support » Theme: GeneratePress » Fast but misses Woocommerce good stuff

  • Very nice and easy theme to use, if you are a developer or a simpel user Generatepress would help you create your site as you wanted to make it.

    I give three stars as it has not a very nice look on woocommerce sites and still some issues there, i like it to use with woo as is a fast theme and i like it to be like this , but needs some improvements also more templates for woocommerce sites as Woo is one of the most used plugins in WordPress.

    It looks like they focus more on simple sites or blogs as woocommerce is more hard to customize and makes your site a bit slower, something that i guess is out of the philosophy of generepress.

    • This topic was modified 1 year, 2 months ago by samiamithis.
Viewing 8 replies - 1 through 8 (of 8 total)
  • Theme Author Tom

    (@edge22)

    Hi there,

    Thanks for the feedback!

    WooCommerce itself makes it quite difficult to build a good-looking store without sacrificing performance, unfortunately. I know they’re working on improving this with their blocks – it’s just not quite there, yet.

    However, we’re working on a handful of new WooCommerce sites for the library right now. We’re also working on some new WooCommerce-specific features in the next version of our pro version to address some of the shortcomings.

    If you have any specific feedback when it comes to the issues you’re having, feel free to get in touch: https://generatepress.com/contact

    While the number of stars is a little disappointing, I appreciate the feedback. I hear you, and we’re working on it 🙂

    Thanks again!

    Thread Starter samiamithis

    (@samiamithis)

    Thank you for letting me know that you are working in new features there, also i know that Woo has huge issues with performance and i follow them on Github and i see the progrees they are doing.

    Still believe that Themes are nothing without supporting Woocommerce, i just dont know if WordPress would be what it is without Woocommerce and that saying, if Themes would exist they way they exist right now without Woo..

    So i feel that Woocommerce should be high priotity for Theme Developers and Block Plugins.

    There are some issues i am facing with Caching Plugins like WP rocket & Flying Pages when i use Critical CSS aka Unused CSS , where they brake the columns picked by Generatepress exp. ( Three Columns – > becoming One ) etc.

    This is one but i am not sure if is a amateur way of generated critical css or the themes itself, wp rocket said that is the theme but i dont count so much on them as i see many bugs from their side.

    You are right for the stars, it was not a fair judge.

    • This reply was modified 1 year, 2 months ago by samiamithis.
    Thread Starter samiamithis

    (@samiamithis)

    By the way some CRITICAL errors when of Generatepress with Woocommerce in the log files.

    This type of critical errors are very common when using gp with woo.

    CRITICAL Uncaught Error: Call to a member function get_cart_contents_count() on null in … / path

    www/wp-content/themes/generatepress/footer.php(59): do_action(‘generate_after_…’)
    www/wp-content/plugins/gp-premium/woocommerce/functions/functions.php στην γραμμή 1260

    2020-11-21T22:31:22+00:00 CRITICAL Uncaught Error: Call to a member function get_cart_contents_count() on null in ../www/wp-content/plugins/gp-premium/woocommerce/functions/functions.php:1260
    Stack trace:

    /www/wp-includes/class-wp-hook.php(287): generatepress_wc_add_to_cart_helper(”)
    /wp-includes/class-wp-hook.php(311): WP_Hook->apply_filters(”, Array)
    /wp-content/themes/generatepress/footer.php(59): do_action(‘generate_after_…’)
    /www/wp-content/plugins/gp-premium/woocommerce/functions/functions.php στην γραμμή 1260

    This issues are known , as i have noticed other people on your forum to talk about those, but i still see them after a lot of months that this has been said.

    • This reply was modified 1 year, 2 months ago by samiamithis.
    Theme Author Tom

    (@edge22)

    Thank you for reporting back! Really appreciate it.

    There are some issues i am facing with Caching Plugins like WP rocket & Flying Pages when i use Critical CSS aka Unused CSS , where they brake the columns picked by Generatepress exp. ( Three Columns – > becoming One ) etc.

    We’ve seen this when caching plugins ignore the media attribute that our WC mobile CSS file has. We’ve actually already improved this in 1.13.0 (due out early 2021). I’d be happy to take a look if you’d like to open a support topic just to make sure the fix we’ve implemented will work for you.

    As for the errors you mentioned – we’re using the exact code suggested by WooCommerce here: https://docs.woocommerce.com/document/show-cart-contents-total/

    The function that error is mentioning is this part: WC()->cart->get_cart_contents_count()

    This should always work and not cause any errors as long as WooCommerce is loaded. I suppose it’s possible that caching is breaking the function itself. We could add some additional checks in there to make sure it doesn’t return an error, but this is something that may need to be investigated between caching and WooCommerce, as this code definitely isn’t unique to the theme. I’ve made a note to run some tests.

    Thanks again!

    Thread Starter samiamithis

    (@samiamithis)

    Hello Tom,

    Sorry to say that, but both of the two bugs i have said is only happening with Generatepress, have tested the same set up ofc with also minimal themes one good example is the default themes of WP, and have never seen this kind of errors specially with the get_cart_contents.

    This is the reason in the beggining i said that This Theme even if it has a nice philosophy for a simple fast woocommerce theme, finally is not so well optimized – bug free for woo.

    By the way maybe you should consider more the caching plugins and not only autoptimise, as you say that Generatepress is the faster theme our there , i guess the people you approach are people that they use a lot of caching plugins.

    • This reply was modified 1 year, 1 month ago by samiamithis.
    • This reply was modified 1 year, 1 month ago by samiamithis.
    • This reply was modified 1 year, 1 month ago by samiamithis.
    Theme Author Tom

    (@edge22)

    Yes, that function does exist in GeneratePress if you turn on the menu cart option, and it is generating an error with your current setup. What I’m saying is that the actual code the theme is using is the exact code provided by WooCommerce, and it’s not causing the errors that you’re seeing on the majority of websites using it. If you turned on another theme that has the same code, you would see the same error is likely generated.

    For example, if you Google the error (Call to a member function get_cart_contents_count() on null), you’ll see this is a common WooCommerce error with many different themes/developers.

    Our users can use any caching plugin with GeneratePress – we don’t only suggest Autoptimize. I personally use WP Rocket on a couple of websites as well. I do prefer server caching instead of a plugin when possible.

    In this case, there’s an incompatibility between your setup and a core WooCommerce function. If you’d like to open a support topic, we can dig in a little bit to see if we can see the cause 🙂

    Thanks!

    Thread Starter samiamithis

    (@samiamithis)

    Hallo Tom, i see that and i accept it, i have never seen it yet with Storefront but never had a storefront live site with actuall orders and working like a previous woocommerce like Generatepress.

    As for the Caching , all the issues with unusead css for me have been with GP Theme.

    Today i was working with WP SHOW POST , onother plugin that is from You , and when i activated a simple related posts , guess what happen , it broke..

    So saying this something is missing and this is the reason i started this post.

    Do not take my comments as a bad review or dont feel that i am not happy client of you, just take it as a real feedback of one of your custommer ( 4 years already) so you can be better and improve some parts ( Please ).

    I believe Generatepress is probably the Best Theme out there with THE BEST SUPPORT in wordpress community! just as you know there are some ( for me ) critical improvements that you must do asap.

    Keep Safe Man

    • This reply was modified 1 year, 1 month ago by samiamithis.
    Theme Author Tom

    (@edge22)

    Today i was working with WP SHOW POST , onother plugin that is from You , and when i activated a simple related posts , guess what happen , it broke..

    Feel free to open a support topic with some more info on what broke, exactly. Will be happy to take a look.

    We’re constantly working on improving the theme in all areas, including WooCommerce. I’m not 100% clear on the critical improvements you’re mentioning, but I’d love to know more. The review area isn’t great for long conversations, so feel free to get in touch if you have any specific suggestions: https://generatepress.com/contact

    Thanks!

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘Fast but misses Woocommerce good stuff’ is closed to new replies.