Fade and spinner don’t work together

  • Resolved hiksos

    (@hiksos)


    5 years, 3 months ago

    Hey there.

    Thanks a lot for the great plugin. I tried about 4 or 5 different ones and yours the only one which works best and doesn’t break my masonry style. Pretty sure it has a huge potential.

    But… Just one thing. Seems like the fade option and spinner option are mutually exclusive and don’t work together. I tried to add the code into functions.php (because I need more than 300 ms of fade) and modified it in various ways, but the options never work in tandem…

    Any help or advice would be appreciated very much!

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author Florian Brinkmann

    (@florianbrinkmann)

    5 years, 3 months ago

    Hi @hiksos,

    I’m happy that the plugin is working so good for you 🙂

    To your issue: good catch, thanks for the hint! Can reproduce it, will see if I can fix it.

    Best,
    Florian

    Plugin Author Florian Brinkmann

    (@florianbrinkmann)

    5 years, 3 months ago

    I think I found a fix (it seems not to work for iFrames, but images seem to work) and released a beta version with that (https://github.com/florianbrinkmann/lazy-loading-responsive-images/releases/tag/v4.1.0-beta.3 the lazy-loading-responsive-images.zip). Would you give it a try and see if it works for you?

    Thanks,
    Florian

    Plugin Author Florian Brinkmann

    (@florianbrinkmann)

    5 years, 3 months ago

    I made additional changes (https://github.com/florianbrinkmann/lazy-loading-responsive-images/releases/tag/v4.1.0-beta.4). Now it is possible to adjust the animation duration via a CSS variable, like so:

    add_filter( 'lazy_load_responsive_images_inline_styles', function ( $default_styles ) {
	$default_styles = sprintf(
		'%s <style>:root {
	--lazy-loader-animation-duration: 600ms;
}</style>',
		$default_styles
	);
	
	return $default_styles;
} );

    Best,
    Florian

    Thread Starter hiksos

    (@hiksos)

    5 years, 3 months ago

    WOW, thanks a lot Florian! I appreciate it very much. Will try it in a short time and let you know if it works 🙂

    Thread Starter hiksos

    (@hiksos)

    5 years, 3 months ago

    Just tested the Beta 4 and it works great with the CSS variable you provided above 🙂 Thank you very much, Florian, wish you best of luck with your plugin!

    Plugin Author Florian Brinkmann

    (@florianbrinkmann)

    5 years, 3 months ago

    Hi @hiksos,

    you’re welcome! Thanks for testing, happy to hear that it works now 🙂 I will release the final version shortly, just noticed that a new version of lazysizes was released, will include that before.

    Thank you very much, Florian, wish you best of luck with your plugin!

    Thanks! 🙂

    Best,
    Florian

    Plugin Author Florian Brinkmann

    (@florianbrinkmann)

    5 years, 3 months ago

    I just released the final version. To get it, you need to manually upload the files of the final version, or manually decrease the plugin version number in the main plugin file (the number in the beta is the same as in the final release, so the update routine will think you already have the new version).

    Thread Starter hiksos

    (@hiksos)

    5 years, 3 months ago

    Awesome, thanks again! 🙂
    Best wishes.

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘Fade and spinner don’t work together’ is closed to new replies.