External images - [Peadig's Twitter Feed: Embedded Timeline WordPress Plugin] Review | WordPress.org

Ryan Hellyer
(@ryanhellyer)

11 years, 9 months ago

The WP Twitter Feed widget plugin loads images from an external source. They need to be hosted locally, both for performance reasons and to ensure they don’t break when using https.

Here is a Diff. which fixes the problem.
http://stuff.ryanhellyer.net/images-fix.diff

EDIT: I wrote a plugin to correct for these problems … http://geek.ryanhellyer.net/products/wp-twitter-feed-fix/

Viewing 4 replies - 1 through 4 (of 4 total)

Thread Starter Ryan Hellyer
(@ryanhellyer)

11 years, 9 months ago

It seems there are some other images which need converted to https too. I’ll have another patch ready soon.

Thread Starter Ryan Hellyer
(@ryanhellyer)

11 years, 9 months ago

There appears to be a dead function called twitterintentjs() in the plugin too. It may pay to remove that. It loads JS from Twitter anyway, and it would be nice to avoid having to do that.

Thread Starter Ryan Hellyer
(@ryanhellyer)

11 years, 9 months ago

I also noticed that it seems to be using output buffering, but I don’t think the buffer is ever actually used. I removed it and it seems to be working just fine without it.

Here’s a new diff.
http://stuff.ryanhellyer.net/images-fix2.diff

Plugin Author Alex Moss
(@alexmoss)

11 years, 5 months ago

Hey Ryan,

The PRO version of the plugin now has this option 🙂

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘External images’ is closed to new replies.

In: Reviews
4 replies
2 participants
Last reply from: Alex Moss
Last activity: 11 years, 5 months ago