It should be grabbing all the assets in url() statements and downloading them. Generally, the intention there is you should ideally be using your own CDN rather than a 3rd party so you can ensure control of the requests and minimize DNS lookups. What the font-face statement has is not modified passed conditionally adding font-display: swap
Let me know your thoughts 🙂
Thread Starter
Rookie
(@alriksson)
Yeah totally agree but the function to grab fonts have some hiccups, and normally using other ways to grab them and load locally in the edge. And don’t like that your plugin loading them ass tff instead of woff2 and removing just font-display: swap;.
1) An option to exclude google fonts for my other solutions when I don’t want your plugin to grab.
2) Serve modern format for the font, woff and woff2 for supported browser together with not stripping the front-display: swap; and listen to the servers TTL it is loaded from. If local listen to origin if CDN listen to edge TTL 🙂
Yeah totally agree but the function to grab fonts have some hiccups, and normally using other ways to grab them and load locally in the edge
As stated the functions ONLY rewrite URLs and download files. Other than that, how the files are actually structured is a Google problem. See https://github.com/pcfreak30/rocket-async-css/blob/master/lib/Rocket/Async/CSS.php#L898 and https://github.com/pcfreak30/rocket-async-css/blob/master/lib/Rocket/Async/CSS.php#L1352.
Thanks.
Thread Starter
Rookie
(@alriksson)
Ok but I don’t agree and there is something that isn’t working as expected:
1) Works and loads woff2 without your plugin.
2) Work with other plugin to load the google fonts locally
3) Works with my other solution.
Both 2 and 3 with woff 2 and swap 🙂
I would need to see CSS code example/comparisons of it before my plugin and after processing and the problem to try and identify any bugs in processing.
Thanks 🙂
