Excerpt shows … although full text shown (It’s counting chars, not words)

Resolved eggnstone
(@eggnstone)

2 years, 5 months ago

The excerpt shows … although the full text is shown.

I am using “limit words”, not “limit characters”.
I think it’s using the word count as a character count.
If I increase the word count (although it’s already showing the full text) until the number of words is high enough for the number of chars to fit, then it works (i.e. doesn’t show the … anymore).

Viewing 11 replies - 1 through 11 (of 11 total)

Plugin Author Daniele Scasciafratte
(@mte90)

2 years, 5 months ago

I don’t understand if the issue is that the excerpt showed or the text generated is using the wrong method to limit the text itself.
Anyway to limit as default is by characters, if the checkbox is checked will use words but the same number defined.

It is missing that stuff in the plugin documentation on https://docs.codeat.co/glossary/ I am working on it
Thread Starter eggnstone
(@eggnstone)

2 years, 5 months ago
The issue is about the excerpt in the tooltip box.

E.g. I set a 10 word limit.
Then I expect no “…” on the excerpt if the full text is shorter or equal to 10 words.

But it seems to use the “10” as a “character limit” although it’s set to words.
Therefore an excerpt with 10 chars has no “…”, but an excerpt with 20 chars (but less than 10 words) does show “…”.

Or explained differently:
```
- Use words: yes
- Limit: 10
- Full text: "1234567890 1234567890" (21 chars, 2 words)
- Expected excerpt "1234567890 1234567890"
- Actual excerpt   "1234567890 1234567890..."
```
- This reply was modified 2 years, 5 months ago by eggnstone.
Plugin Author Daniele Scasciafratte
(@mte90)

2 years, 5 months ago

Well in this case the words are 2, that option set a limit of 10 words in the tooltip.

1234567890 1234567890 are 2 words separated by a space, if you want for characters you need to uncheck, so it will use them.

The dots aren’t added as the excerpt wasn’t cut.

Thread Starter eggnstone
(@eggnstone)

2 years, 5 months ago

Sorry, I don’t understand.
It seems to me that you have a bug.
The “…” in the tooltip excerpt only makes sense when there is more text.
And that should work regardless if I have chars or words selected.

Plugin Author Daniele Scasciafratte
(@mte90)

2 years, 5 months ago

No the behavior is right.
The dots are added if the new text generated is different after the cutting.
I mean if you set 10 words as limit and the words are just 2 the dots aren’t added.
If the words were 11 the cut will be at 10 and the dots will be added.

Thread Starter eggnstone
(@eggnstone)

2 years, 5 months ago

>I mean if you set 10 words as limit and the words are just 2 the dots aren’t added.
That’s exactly my point: The dots are added although they should not be.

Thread Starter eggnstone
(@eggnstone)

2 years, 5 months ago

You can see it in action on https://kaisgolfguide.de
Limit the excerpt by words: yes
Excerpt length in characters or words: 20
Result: … although full text already visible

Plugin Author Daniele Scasciafratte
(@mte90)

2 years, 5 months ago

Ok so after few testing seems that we are not detecting right when is used the words counter.
I will look on that but I am not sure when I can do a release for this fix.

Thread Starter eggnstone
(@eggnstone)

2 years, 5 months ago

Thank you or looking into it.
It was a bit difficult to explain but I’m glad you could reproduce it now 🙂

Plugin Author Daniele Scasciafratte
(@mte90)

2 years, 5 months ago

I am releasing now the new version with this bugfix.

Thread Starter eggnstone
(@eggnstone)

2 years, 5 months ago

That was quick after all!
I got the update and it looks good now.
Thank you.

Viewing 11 replies - 1 through 11 (of 11 total)

The topic ‘Excerpt shows … although full text shown (It’s counting chars, not words)’ is closed to new replies.