ESI Nonces problem with EDD

Hello,

After some discussions with the LiteSpeed tech team, we stumbled upon an ESI logic limitation which doesn’t allow nonce creation + validation within the same page request with ESI enabled, which was the case in the EDD-Recurring addon.

This kind of operation doesn’t have any pratical sense, thus why the bug wasn’t spotted before. The solution is to remove the nonce from the ESI nonces rules list. I’ll contact EDD team to let know that this nonce verification can be removed in the code, as it is useless.

If someone need it, here is the filter I’m using to remove global EDD ESI nonces rules added within the LSCWP plugin:

/*
 * LiteSpeed ESI: Remove global EDD nonces rules
 */
add_filter('litespeed_esi_nonces', 'my_edd_esi_nonces', 20);
function my_edd_esi_nonces($nonces){
    
    // check nonces
    if(empty($nonces)){
        return $nonces;
    }
    
    $modified = false;
    
    // loop
    foreach($nonces as $i => $nonce){
    
        // bail early if not edd
        if(strpos($nonce, 'edd-') !== 0 && strpos($nonce, 'edd_') !== 0){
            continue;
        }
        
        // unset
        unset($nonces[$i]);
        $modified = true;
    
    }
    
    // reorder array
    if($modified){
        $nonces = array_values($nonces);
    }
    
    // return
    return $nonces;
    
}

Thanks for your help!

Regards.