Support » Plugin: eShop » [Plugin: eShop] eShop won't disable default styling

Viewing 10 replies - 1 through 10 (of 10 total)
  • esmi

    (@esmi)

    Forum Moderator

    And?

    And it shouldn’t be happening, since this defeats the who purpose of disabling the default styling so that you can make your own, isn’t it?

    esmi

    (@esmi)

    Forum Moderator

    The 2nd CSS block is for the Test mode bar only and both blocks can be overridden by your own CSS.

    I’m aware they can be overridden with !important tags. But again, in my opinion if there is an option that allows to disable default styling it should disable all font-end styling completely, especially if its inline styles.

    Thanks

    esmi

    (@esmi)

    Forum Moderator

    Not if you also have to provide basic CSS for non-technical users. Without that .eshoppanels CSS (for example), the panel display will fall apart in IE8. Anyone who is capable of creating their own eShop CSS is also capable of overridding those two blocks, so the lesser of the two evils was chosen. This was a deliberate design decision and it won’t be changing in the short term.

    Yes but don’t you think that if somebody deliberately chooses to disable the default CSS, the person actually knows what he is doing and is capable to provide IE8 fallbacks if needed?

    In fact, if somebody decided to use “display: inline-block;” instead of floats, or perhaps uses the extended margin syntax (“margin-right”, “margin-left”, etc) it will make his life harder since he also got to know how to “revert” the inline styles applied.

    To sum it up, in my opinion there is nothing wrong with including the basic css + inline styles for users who chooses to keep the “default style” but in case somebody chooses to deliberately disable the default styling, it shouldn’t add any styles at all.

    If somebody non-technical wants to make small changes, they have the customization box, which is separate from the default styling radio buttons.

    P.S – its a simple matter of adding an IF statement to check if the “use default styles” have been set to “no” and then make sure to prevent the inline styles to be included with wp_head() / wp_footer().

    esmi

    (@esmi)

    Forum Moderator

    This was a deliberate design decision and it won’t be changing in the short term.

    Thanks for the reply, but please consider making that change 🙂

    Plugin Author elfin

    (@elfin)

    ahhhh, on re reading this I see what you mean.

    Luckily that can be removed easily enough with a remove_action.

    remove_action('wp_head','eshop_ie_fix');

    Thanks for the reply Rich.

    In my opinion this should be considered a bug; since it goes against the logic of having a “disable default styles” option.

    It would help a lot if you could disable the addition of styles properly in the source code with a conditional.

Viewing 10 replies - 1 through 10 (of 10 total)
  • The topic ‘[Plugin: eShop] eShop won't disable default styling’ is closed to new replies.