Support » Plugin: Debug Meta Data » esc_html on $value_array and $valueAr

  • First off, thanks for this plugin. Its great.

    Now I just noticed something that may/may not be by design. Essentially when you output the content of meta, you’re not escaping the value. For cases where your meta can contain script tags they will execute on the edit screen.

    Consider the following:

    foreach ( $value as $name_array => $value_array ) {
        echo $name_array . '  =>  ' . esc_html( $value_array );
        echo var_dump( $value_array );
    }

    Without the esc_html, the following immediately redirects you to another page. If this was on a server I don’t know a lot of people that would be able to modify and stop the code from executing.

    <script>
        window.location = "http://www.example.com";
    </script>

    If this is by design, it is what it is. But if you’re not opposed to escaping the output I would highly recommend it.

    Thanks!

    https://wordpress.org/plugins/debug-meta-data/

Viewing 1 replies (of 1 total)
  • Plugin Author Ahmad Awais

    (@mrahmadawais)

    It was an intentional decision by design. This plugin is strictly meant to be used over localhost. What do you think? What I can do is add a settings page to disable it and have two enable options with or with escaped data?

Viewing 1 replies (of 1 total)
  • The topic ‘esc_html on $value_array and $valueAr’ is closed to new replies.