Hi @krko,
Thanks for reporting this bug!
I’ll have it fixed by the end of this week 🙂
Have a wonderful day!
Thread Starter
krko
(@krko)
Hey @cybr,
Thanks as always for your prompt response. I just thought I should let you know that the bug I reported earlier still exists.
Thanks!
krko
Hi @krko,
Have you updated to the latest version (2.9.3)? It should’ve been solved.
Cheers 🙂
Thread Starter
krko
(@krko)
Hey @cybr
Yes of course. I’m running 2.9.3
krko
Thank you @krko for checking it out.
I suspect the given URL might contain something like this (notice the double &):
http://example.com/?a=1&b=2&&c=3
It might be that an empty add_query_arg()
call is used by any other plugin, too.
I’ll contact the PressApps Knowledge Base plugin authors so they’re aware of the issue.
In the meantime, I’ll see if I can find out the cause and a complementary permanent fix that works for everyone.
Have a wonderful day 🙂
Thread Starter
krko
(@krko)
Hey @cybr,
Thanks as always for your help! The preview url looks like this:
https://mydomain.com/?post_type=knowledgebase&p=45178&preview=true
So that’s a single & even though that 8 sure looks like a double & on first glance 🙂
All best.
krko
Thanks for the info @krko,
Then my main suspect is a stray add_query_arg()
call towards global $wp_query
.
However, I can’t tell for sure without looking into and testing the third party code.
Let’s await PressApps’ response.
I hope the debug output isn’t too much of an inconvenience.
Thread Starter
krko
(@krko)
Hey @cybr how are you?
From the last time I’ve spoken to you I’ve switched to Heroic Knowledge Bade plugin but the error persists. Here is the error I’m getting:
Warning: strpos(): Empty needle in /path-to/wp-content/plugins/autodescription/inc/classes/generate-url.class.php on line 789
The guys at Heroic are more communicative, so you should get an answer from them if you need.
Just thought I should update you.
krko
Hi @krko,
I’m great! Thanks for asking 🙂
In my recent adventures regarding URL manipulation, I discovered some php.ini adjustments can greatly affect URL parsing and rendering.
For this reason, I’ve applied another check right where the error is to prevent the error from executing. Now, it’s a band-aid rather than a real fix, but it shouldn’t affect real-world output. It will be shipped with 2.9.4.
I’d still like to investigate this further to find the real causation to prevent future errors. So I’m eager to receive feedback.
Thread Starter
krko
(@krko)
Sure I’ll let you have my findings once it’s out.
Thanks for all your work!