Fix will be in views/settings.php line 80:
Change:
init_rse_overlay_editor( overlayEditorCallback );
to:
init_rse_overlay_editor( 'overlayEditorCallback' );
Plugin Author
resoc
(@resoc)
Hi Robin,
Oh 🙁 Thank you for reporting!
For the record, there was another instance of this mistake in includes/lib/class-resoc-social-editor-facebook-editor.php
. The fix is committed, ready to be deployed.
However, something puzzles me. You said that “the popup will not show”, an obvious bug. But the issue you mention with overlayEditorCallback
is a warning. An ugly one, for sure, but still a warning and the automatic conversion to string is the actual fix for this mistake. Which is also why I didn’t discover this issue myself.
So I was wondering if this fix alone will help you, or if there is another problem somewhere? Did you notice another error, for example in the Chrome Dev Tools console? (I understand you are a developer, this is why I’m asking directly).
Regards,
Philippe
Plugin Author
resoc
(@resoc)
Hi Robin,
Plugin v0.0.12 was published a minute ago. It includes the fix you suggested in your second message. Would you be so kind to tell me if this is fixing the issue on your side?
Regards,
Philippe
Plugin Author
resoc
(@resoc)
Hi Robin,
I am closing this issue. Don’t hesitate to reopen it if the issue is still present.
Regards,
Philippe