Support » Plugin: Flattr » Error in flattr button style introduced in 1.0?

  • Resolved rolfkleef

    (@rolfkleef)


    After I updated from 0.99.3 to 1.0.0, I see javascript buttons instead of image buttons: the option Button Type is ignored.

    I had a look at the changes in the code, and probably found the problem at line 484:

    -                switch (get_option(flattr_button_style)) {
    +                switch (empty($type) ? get_option(flattr_button_style) : $type) {

    Before looking at the setting of the option, it first checks whether $type is empty. But since it is set to ‘Javascript’ as default value if no parameter is given, it won’t ever be empty.

    I don’t have a fix that does use $type, but just reverted that change to get my site back to using the image button. It might take a little more effort to get the logic right with optionally overriding $type…

    http://wordpress.org/extend/plugins/flattr/

Viewing 3 replies - 1 through 3 (of 3 total)
  • rolfkleef

    (@rolfkleef)

    oops, should have mentioned that I’m referring to the code for getButton() in flattr.php…

    Plugin Author VoxPelli

    (@voxpelli)

    Rather embarrassing bug :/ Fixed in 1.0.1 which is out now – thanks for pointing it out!

    rolfkleef

    (@rolfkleef)

    thanks for the quick fix 🙂

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Error in flattr button style introduced in 1.0?’ is closed to new replies.