Support » Plugin: SportsPress - Sports Club & League Manager » Equation-based performance disappeared after 2.6.11

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Brian

    (@brianmiyaji)

    @ramzesimus Thanks for spotting that! The additional logic was added to allow for player performances totals to be calculated on the fly, which would automatically happen when columns were missing from the array. You’re right that this would affect custom templates using the array as-is without the built-in templates, so I’ve reverted this logic and instead added a format check in the template loop:

    https://github.com/ThemeBoy/SportsPress/commit/ea19cc4ec9b0ef9bcc04bd2b2f8400da85d15f8f

    We’ve just released version 2.6.12 with this fix and a couple other minor tweaks. Thanks!

    Hi @brianmiyaji,

    Thanks for your fast fix! It works great! 🙂

    Best Regards!
    Ramz

    @brianmiyaji just a small question. So now the total event equation-based performance is calculated based on individual players performances and doesn’t take values from the Total row. See screenshot http://take.ms/HtVHJ

    In the perfect world I agree that each player has filled performances, but in the real world many users just fill out the Total event stats.

    Of course after moving this logic to the template we can overwrite it (and I’ve done it already) but I really doubt that the current logic would be useful for users.

    Best Regards!
    Ramz

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Equation-based performance disappeared after 2.6.11’ is closed to new replies.