Edit Flow Broken In Parts In WP 3.6

  • Jeffro

    (@jeffr0)


    10 years, 7 months ago

    I’ve discovered too many issues with Edit Flow and WordPress 3.6 that I have to mark this plugin as broken until most of the issues get fixed. Here is my experience thus far.

    After upgrading to WordPress 3.6, I discovered that I could not preview posts using the custom post status of Pitch. This took me forever to diagnose and figure out but it has something to do with the plugin not generating a revision which is shown as the post preview when the preview button is selected. I have demonstrated this bug to the developers at Automattic who are in control of this plugin and they are currently developing a fix. If you experience this problem with Edit Flow, I suggest you set your Default post status to Draft since the Draft post status works as expected.

    There is another bug that’s in the core which if you’re quick editing the post to change post status or heck do anything from quick edit screen (then the timestamp gets saved)… Which means when you later publish the post and if you weren’t paying close attention… your post wouldn’t go out immediately… it was backdated to the day that you first made the quick edit.

    I’ve also discovered that my Archive page shows a bunch of errors related to an Edit Flow function Warning: Missing argument 3 for EF_Custom_Status::fix_preview_link_part_two() in /home/blah/domain.com/wp-content/plugins/edit-flow/modules/custom-status/custom-status.php on line 1458 dealing with custom statuses. It’s a mess and this plugin needs some serious love.

    http://wordpress.org/plugins/edit-flow/

Viewing 12 replies - 1 through 12 (of 12 total)
  • Plugin Author cojennin

    (@comradefuzz)

    10 years, 6 months ago

    Hey,
    Sorry about all the problems you’re encountering. Would you be able to create some new tickets on GitHub documenting the issues you’re encountering? https://github.com/Automattic/Edit-Flow/issues

    It would be tremendously helpful in triaging what needs to be fixed. If not, no worries, I’ll try to cover what you’ve put here.

    Working to get some fixes out quickly, so stay tuned!

    Thanks!

    -CJ

    Thread Starter Jeffro

    (@jeffr0)

    10 years, 6 months ago

    I’ve never created tickets on Github before so I’m not sure I am of much help there. I hope you can somehow create the tickets for me as I clearly outlined each issue and what I believe to be the cause. Hope to see an update released soon! Too many people counting on this plugin!

    DanYork

    (@danyork)

    10 years, 6 months ago

    I raised the three issues as tickets in Github:

    https://github.com/Automattic/Edit-Flow/issues/209
    https://github.com/Automattic/Edit-Flow/issues/210
    https://github.com/Automattic/Edit-Flow/issues/211

    I see from another issue raised by cojennin that there way be a fix for part of this already.

    Thread Starter Jeffro

    (@jeffr0)

    10 years, 6 months ago

    Thanks for doing that Dan.

    Plugin Author cojennin

    (@comradefuzz)

    10 years, 6 months ago

    Hey,
    Quick follow up regarding the archives issue. What sort of plugins and theme are you currently using? Trying to trigger this issue but having some difficulty getting it to occur. The archives you’re referring to are your daily, monthly, yearly archives, correct?

    Thanks,
    CJ

    Thread Starter Jeffro

    (@jeffr0)

    10 years, 6 months ago

    I was using a very old archive plugin called KG Archives which is nowhere to be found now. I did fix the issue by deactivating edit flow and then my archive plugin. I then reactivated both of them and the issue went away.

    Plugin Author cojennin

    (@comradefuzz)

    10 years, 6 months ago

    Good to hear that’s fixed! If you have a minute, would you be able to walk through the issue you’re having with Quick Edit?

    I’ll list the steps I did to try and reproduce:
    1) Install a WordPress instance with/with out EditFlow
    2) Create a post and save it as a draft
    3) Go back to the same post a little bit later with Quick Edit and switch it to publish
    4) The post shows up as being published when I first created it (without EditFlow being installed at all).

    The steps are identical whether I have EditFlow or not.

    I also tried the following with and without EditFlow:
    1) Install a WordPress with/without EditFlow
    2) Create a post and save it as a draft
    3) Go back to the same post a little bit later with Quick Edit and do nothing but hit save
    4) Go to the post edit screen a little bit later and hit publish

    Whether I had EditFlow installed or not, when I went to the post edit screen and clicked publish, it stayed at the date when I did nothing but hit save with Quick Edit. Are you experiencing something similar, or did the steps to reproduce differentiate?

    Thanks,
    CJ

    Thread Starter Jeffro

    (@jeffr0)

    10 years, 6 months ago

    I got in touch with someone that reported this bug to me. I sent him a link to this thread and will have him explain how to reproduce it.

    Plugin Author cojennin

    (@comradefuzz)

    10 years, 6 months ago

    Excellent, thanks!

    Syed Balkhi

    (@smub)

    10 years, 6 months ago

    Ok there are two bugs related to the date.

    We use edit flow to keep an organized work flow (i.e author submits pitches, editors review it and assigns it and so on).

    Now as an editor if I’m reviewing the pitches and want to change it to assigned, I can’t use the Quick Edit feature in WordPress. Because it will leave a timestamp there…. it won’t publish the article but instead of having the article to be published immediately, now there will be a time stamp. So basically when publishing the article, you have to remember to adjust the timestamp, so the post is not backdated.

    The above bug is a core bug not just with Edit Flow.

    Now there is a second issue that is with Edit Flow and here is how to replicate it.

    1. Create a New Post under status Pitch
    2. Change the Status to Assigned
    3. User then submits it to Pending Review
    4. Editor tries to push it to Ready to Publish but the dates are assigned.

    Basically if the same user tries to change the status between edit flow statuses, then a timestamp is marked (i.e it is changed from Publish immediately to the date when the post was first created).

    This can be avoided if you switch back to Draft and then switch to another Edit Flow status. Pretty annoying bug, but we deal with it mainly because nothing else comes close to Edit Flow functionality just yet.

    Plugin Author cojennin

    (@comradefuzz)

    10 years, 6 months ago

    Thanks for the comprehensive response! Regarding the second issue: I spent some time tackling this and you can check out/test the changes here.

    It should fix the following issues I noticed:
    Issue #1

    1. Create a New Post under status Pitch
    2. Change the Status to Assigned
    3. User then submits it to Pending Review
    4. Editor tires to push it to Ready to Publish and the Publish status should continue to say immediately.

    Issue #2

    1. Create a New Post under status Pitch
    2. Leave post and revisit in an hour or more
    3. Click editnext to Publish immediately
    4. Previously, the date the post as first saved. Now, the date should show up as the current time (as it does when Edit Flow is deactivated)

    If you have the time to spare for testing out this fix, that would be tremendously helpful. The faster this patch can be tested and debugged, the quicker it can be placed into Edit Flow core.

    Plugin Author cojennin

    (@comradefuzz)

    10 years, 6 months ago

    Hey,
    So the above issue (the one not related to core) should be fixed by the following commit: . If you can, feel free to download from GitHub and test it out.

    Thanks,
    CJ

Viewing 12 replies - 1 through 12 (of 12 total)
  • The topic ‘Edit Flow Broken In Parts In WP 3.6’ is closed to new replies.