Support » Plugin: Sermon Manager » Download Files Not Showing Audio File when notes are added

Viewing 8 replies - 1 through 8 (of 8 total)
  • Thread Starter techbizgurl

    (@techbizgurl)

    Wondering if there are any updates or resolutions to this?

    Did you ever get this solved? We were having the issue where our notes were never showing up but just our MP3. I dug into the code and found that it does not work for us now because our notes are just links to Evernote so they are not “attachments” in WordPress.

    You can see them on http://northstarfamily.org/podcasts/acts-171-15-a-heart-for-the-lost/ for an example now of how they show both by making the edit below…

    I was able to fix it but have to edit a file so it gets lost on update, meaning you have to do it each time. Here’s what I did that can hopefully help you or someone else until the change in ownership is done and I can file a proper bug report and/or patch with the new guys…

    Open the file /includes/template-tags.php. You can do this in WordPress Admin by clicking “Edit” next to “Sermon Manager” in the Plugins list and then on the right sidebar find “sermon-manager-for-wordpress/includes/template-tags.php” and click it!

    Find this line (I use Control+F in Chrome on Windows to find on page):
    $attachments = get_posts($args);

    Change it to this:
    $attachments = 0;

    Save it and go view a sermon and see what happens!

    Plugin Author wpforchurch

    (@wpforchurch)

    Hi @andrewteg,

    Thanks for that thorough feedback. I have just logged that as an issue in the new repository in GitHub.

    We will update the repo link the upcoming update, we’ll welcome issues to be created in there directly (for those who prefer that).

    I will update you here when this specific issue has been resolved. Thanks for your patience!

    Thanks,
    Igor

    Plugin Author wpforchurch

    (@wpforchurch)

    Hi @andrewteg @techbizgurl,

    This is now fixed in the latest update 2.0.6, could you kindly update and let me know how it goes?

    Thanks for your patience,

    Igor

    Thread Starter techbizgurl

    (@techbizgurl)

    Thanks so much for chiming in @andrewteg. Super helpful!

    @wpforchurch I updated the plugin today and it updated and looks right where it’s showing both the MP3 and notes. http://woodvillagebaptist.org/sermons/john-jesus-god/

    Thanks all!

    Plugin Author wpforchurch

    (@wpforchurch)

    Great news @techbizgurl, thanks for letting us know.

    Thanks. It seems to be showing it twice for us now when it is a WP attachment, like this one that has the MP3 and Bulletin as attachments: http://northstarpulaski.org/podcasts/book-of-acts-1716-34/

    Then it shows only once for external links (or non-attachments) like:
    http://northstarfamily.org/podcasts/acts-181-17-ministers-breaking-sad/

    I really like the dashicons view so I’ll probably just do the same thing to not show attachments but leave it for now for you to look at. I also think the link @techbizgurl gave is doing the same thing as it’s showing her notes twice I believe.

    I do appreciate the improvement since I would rather have it show twice than not at all, so thank you for getting on that so quickly 🙂

    //Enter Nerd Talk…

    My question looking at the code is if the $attachments code block is even needed. Is it possible to have an attachment that is not the MP3, Notes, or Bulletin? If not, then can that block just be removed? I know some people are probably using it differently than us, so if that is not an option, I totally understand!

    If so, one thought would be to store the attachment URL and name into an array and then if the URL matches the audio, notes, or bulletin URL, use the actual name instead of just “MP3/Notes/Bulletin” with the icon. Finally, just show any attachments that don’t get matched below with a standard icon. That would eliminate duplication, show everything with an icon, and put MP3/Notes/Bulletin first no matter what. An added bonus would be us as end users being able to control the name shown if it is an attachment. If that sounds good, I’m happy to code it up and submit it back to you guys for review and inclusion if you like it.

    //End Nerd Talk 🙂

    Nikola

    (@nikolam)

    Hey @andrewteg, thanks for the suggestion!

    Sermon Manager code is located here: https://github.com/WP-for-Church/Sermon-Manager

    You could open an issue there, and PRs are always appreciated! 🙂

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘Download Files Not Showing Audio File when notes are added’ is closed to new replies.