Support » Plugin: Popup Modal » Don't work link in the popup

Viewing 13 replies - 1 through 13 (of 13 total)
  • Plugin Author Tim Eckel

    (@teckel)

    Correct. The entire popup is meant to be clickable, with the print/close buttons. Maybe you could explain your usage so I could better understand what your needs were so I could accommodate.

    Plugin Author Tim Eckel

    (@teckel)

    I did some testing and see what you mean. I’ve released version 1.8 which allows links to work inside your popups.

    Hi,
    good plugin, I have installed the last version of the plugin v 1.8 but I have same issue of @aragosta.
    You can tell me how to fix it?

    Thanks
    Valentina

    Plugin Author Tim Eckel

    (@teckel)

    What do you have set for the “Button Location” for the Popup Options? If you set it to “No Buttons” it may seem like you can’t click the link, but you can. If you set the “Button Location” to “Left”, “Center”, or “Right” it may be more obvious.

    If you still can’t get things working, I would suggest you attach the HTML text source from your popup as well as the Popup Options you have set. That way I can duplicate your settings to and duplicate what you are experiencing.

    Tim

    Hi,
    The HTML of the popup is a simple <a href="http://www.example.com"><img src="..." /></a>

    In my case I have Buttons Location:No Buttons, Print:No, if on the popup I click on the image, the link not working. In this case I expect the link url is opened.

    Could be the function popupClick to edit?

    Right If I use the print functionality (Print:Yes) and the Buttons Location is set to Left-Center-Right and I click on the image in the popup Print action start.

    An alternative is to add the ability to add a button like “Read more” before Print button, and add a setting “Link” with the url and an option to popup click action Close-Print-Link.

    Valentina

    • This reply was modified 4 years, 1 month ago by steplab.
    Plugin Author Tim Eckel

    (@teckel)

    I’ll need your entire actual HTML for the popup and all of the popup options (maybe a screenshot of the options?). I need this to duplicate your problem as I’m not experiencing this at all. I can add an image with a link and when I click on it it goes to the link every time. No issues at all.

    I also don’t totally understand what you’re trying to do. Do you want people to print the popup or go to a link? How would you both print and go to a link? I’m trying to understand what you’re trying to do and what exact settings you’re using.

    If including images in your HTML, make sure to specify the complete URL including domain so I can duplicate your popup 100%.

    I’m having the same problem; also have 1.8 installed. Buttons set to “x to close”.

    site: thecanniballiquorhouse dot com

    Plugin Author Tim Eckel

    (@teckel)

    I can’t duplicate it. That’s why I need the full HTML (with full paths to images) of your popup and all of the settings. That way, I can duplicate it 100%.

    Have you tried using close buttons instead? Have you turned off the print function? The print function is designed so you can click anywhere to print. If you’re trying to print AND have a link, it may work, but I’d need the EXACT popup HTML and settings to see what you’re doing as when I do it it works just fine. Then again, I use mixed media HTML in popups where there’s formatted text and images, not just one giant image for the entire popup. I’m all about SEO value, so I never create images like that, always mixed media.

    settings

    where do you want me to send you the html? I figured it was easier to just look at the source on the live implementation.

    • This reply was modified 4 years, 1 month ago by llungboy.
    Plugin Author Tim Eckel

    (@teckel)

    You can include html inside code tags in a reply here. But, I see that you have the popup running on the mentioned site already. I’ll take a look, thanks!

    • This reply was modified 4 years, 1 month ago by Tim Eckel.
    Plugin Author Tim Eckel

    (@teckel)

    Links work for text, not images. I never thought about using a large image like this because I would design a popup to be a mixture of text and images for better responsive design, user experience, and SEO value.

    With that said, I’m not sure why the link doesn’t work when it’s an image but works just fine for a text link. When building the ability for links to work I only ever tested text links as that’s all I would ever use for a popup.

    I’ll look at the code to see why only text links would be working. But, I’d also suggest making your popups mixed media and only having part of the popup be the link. Also, your image is way too large, it scrolls off the bottom of my screen, which is a typical 1920×1080 display. Using mixed media, it would be far more readable too as the text is also very hard to read as-is.

    PS: Next time I’m in NYC I’ll be sure to check out the Cannibal Liquor House! Love the Pee-wee Herman cycling pics too!

    • This reply was modified 4 years, 1 month ago by Tim Eckel.
    Plugin Author Tim Eckel

    (@teckel)

    Got it sorted out. The issue was that I only thought of making the link a text link, so that’s all I ever tested. When clicking on a text link vs. an image link, JavaScript deals with the target differently. For a text link, the target is the anchor tag, which has the href path. For an image that’s a link, the target is the image not the anchor tag. So, the code was never seeing the href as the target was the image not the anchor tag. Interesting actually.

    In any case, the code now looks at not only the click target’s href but also the click target’s parent href. This is a long-winded way of saying that it’s fixed.

    I’ll update Popup Modal to v1.9 which will address this issue.

    Finally work, Thanks!!

Viewing 13 replies - 1 through 13 (of 13 total)
  • The topic ‘Don't work link in the popup’ is closed to new replies.