Don't call pluggable.php

  • Resolved benfreke

    (@benfreke)


    9 years, 3 months ago

    Hi

    At the top of twinesocial-admin.php you’re doing a require_once on pluggable.php. Don’t do that. As the docblock on pluggable says, “These functions can be replaced via plugins. If plugins do not redefine these functions, then these will be used instead.”

    By including this file, it is breaking other plugins. In my case it is wpmandrill.

    Regards,

    Ben

    https://wordpress.org/plugins/twine-social/

Viewing 2 replies - 1 through 2 (of 2 total)
  • Noah Beane

    (@nj987)

    9 years, 3 months ago

    Thanks, Ben. We’ve fixed this and will push the first within 24 hours.

    Meanwhile, if you wish you can remove the require_once from line 2 of twinesocial-admin.php and change line 172 to: if ( isset($_POST[‘action’]) && $_POST[‘action’] == ‘update’ ) {

    Sorry for the trouble. Thanks for using TwineSocial!

    —Noah

    Thread Starter benfreke

    (@benfreke)

    9 years, 3 months ago

    You need to change the line to this actually:

    if ( isset($_POST['action']) && $_POST['action'] == 'update' && isset($_POST['twinesocial_noncename']) && wp_verify_nonce( $_POST['twinesocial_noncename'], plugin_basename( __FILE__ ) ) ) {

    The nonce throws an error is you don’t check the post value is set first in some cases.

    While we’re at it, you could also remove the closing php tag on line 196 🙂

    Thanks for pushing the fixes so quickly!

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Don't call pluggable.php’ is closed to new replies.