• Resolved simusch

    (@simusch)


    WordPress version: 3.6
    Plugin version: 2.3
    Link to my site: http://www.rohdiamantmusic.ch/album/somewhere/

    I expected the plugin to do this: Progress-Bar in line with the control-buttons

    Instead it did this: breaks to a new line

    Here’s what I’ve tried so far:

    I tried to play with the pixel-calculations in the plugin. after the update, the progress-bar is again on a new line. Didn’t find out where in the CSS the problem is.

    And another thing:

    It would be very nice to have a “Disc” Option for albums like the linked with 2 discs.
    I did a workaround by adding a title “DISC 1” with the file # – but this way the title-numbers are incorrect.

    http://wordpress.org/plugins/html5-jquery-audio-player/

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Maeve Lander

    (@enigmaweb)

    I checked your link and can see the problem in some rogue css in http://www.rohdiamantmusic.ch/album/somewhere/ line 186 I’m not sure quite what file this is coming from – you’ve obviously done some playing around with the plugin files, but if you change the width there to .ttw-music-player{ width:540px !important; } then this will solve your problem.

    Ok now to add some space below the control bar add this code to your theme css:

    .ttw-music-player .player-controls {
        margin: 29px 0 20px 4px !important;
    }

    As a general rule you should always do your customisations like this in the theme css using !important attribute to override any css in the plugin. This avoids problems when you update, because updating a plugin overwrites the previous plugin files. Make sense?

    Thread Starter simusch

    (@simusch)

    thanks, i don’t know why it was working before with my css…

    now i had to add a padding to .player-controls, the bar and the controls went until the left/right border…

    can you say something to my 2-disc request?

    Thread Starter simusch

    (@simusch)

    Hi Maeve

    I found an easy solution for me to add multi-disc support.

    Like before, I added a title named “DISC 1” with the mp3/ogg-links to “#”
    This works fine, as the # is a “fake”-link

    now I added this code to the file “includes/ttw-music-player.php” into the function buildPlaylist() (around line 225):

    var $trackValueReset = 0;
    
    for (var j = 0; j < myPlaylist.length; j++) {
    	var $track = $(markup.listItem);
    
    	//multi-disc track numbering
    	if('#' == myPlaylist[j].mp3)
    	{
    		$trackValueReset = j + 1;
    		$trackValue = 0;
    		$track.attr('style', 'list-style-type:none;');
    	}
    	else
    	{
    		$trackValue = j + 1 - $trackValueReset
    	}
    	$track.attr('value', $trackValue);

    this looks for a file named “#” and hides the list-number for this item and sets the counter for the next title to “1”
    hope you’ll add this simple workaround to a future version so i don’t have to update the file after a plugin-upgrade 🙂

    simon

    Plugin Author Maeve Lander

    (@enigmaweb)

    That’s a clever solution Simon, nice one. I’ll jot this down for consideration, but honestly I’ve never had anyone else ever ask about multi-discs – I’m guessing in the age of digital music this isn’t really a common concern. In general I feel that unless the feature is something a lot of people want it is best to keep the plugin simple, and instead make the code available in the documentation so users can add it if they want.

    Thoughts?

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Display Problems / multiple Discs’ is closed to new replies.