Did you seriously rename .meta files to .php without thinking?

  • _ck_

    (@_ck_)


    8 years, 6 months ago

    I’ve seen a lot of bad code in wp-super-cache but did I just read that .meta files are now stored as .php ?

    How about all the people on shared hosting that have opcaches on php which will now attempt to cache ALL THOSE .PHP files !!!

    Sure if you control your own server and are aware of this you could exclude the directory from the opcache – if you knew that .45 changes this.

    This move is dumbfounding.

    And if you think a die() statement safely prevents additional execution in a php file, you simply do not know the language well enough

    Why not just give people a way to completely disable the legacy caching for logged in users? There is little performance benefit anyway and on a large active site you are just thrashing thousands of files for no reason.

Viewing 2 replies - 1 through 2 (of 2 total)
  • MAzZY

    (@mazzy)

    8 years, 6 months ago

    I’m agreed.
    Bring back as it was before

    joelhardi

    (@joelhardi)

    8 years, 6 months ago

    I would also vote for an option to just disable legacy caching completely.

    Unless I’m wrong, I think it’s enough to just make sure that the if statement in line 497 of wp-cache-phase2.php always evaluates to false, so that the file handle $fr never gets created. i.e. this diff:

    --- wp-content/plugins/wp-super-cache/wp-cache-phase2.php	2015-09-26 17:59:37 +0000
+++ wp-content/plugins/wp-super-cache/wp-cache-phase2.php	2015-10-03 22:14:03 +0000
@@ -494,7 +494,7 @@
 	$fr = $fr2 = $gz = false;
 	// Open wp-cache cache file
 	if ( false == $wp_cache_object_cache ) {
-		if ( !$supercacheonly ) {
+		if ( false && !$supercacheonly ) { // Added "false && "
 			$fr = @fopen($tmp_wpcache_filename, 'w');
 			if (!$fr) {
 				wp_cache_debug( "Error. Supercache could not write to " . str_replace( ABSPATH, '', $cache_path ) . $cache_filename, 1 );
Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Did you seriously rename .meta files to .php without thinking?’ is closed to new replies.