• Resolved Stonehenge Creations

    (@duisterdenhaag)


    PHP Deprecated: edd_download_price_table_row is <strong>deprecated</strong> since version 2.10! Use edd_download_price_option_row instead.

    This is your own code… Please update it.

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Support Mihai Joldis

    (@misulicus)

    Hey @duisterdenhaag

    Thanks for the report. That is a deprecation message so its not really affecting the site functionality in any way but we will be removing the code in the 3.0 release of EDD.

    Thread Starter Stonehenge Creations

    (@duisterdenhaag)

    I know, it is a notice and not a warning. It is flooding by debug log, though.
    Adding a deprecated notice while the same version is still using it seems strange to me.

    Also, will version 3.0 an option to stop EDD logging every query as a new post? Or at least include an option to NOT log everything?

    Payment logs are using a comment type, but every other log entry created a new entry in wp_posts. When I started with EDD my post count was 256. Now, little over a year later I noticed that the newest entry is 8234.

    Plugin Support Mihai Joldis

    (@misulicus)

    Hey there,

    Normally the notices will not be logged unless you have debug enabled in your WordPress configuration file.
    The notice will go away when the extension using the edd_download_price_table_row hook has been updated to stop using it. Any extension which adds variable price options will trigger it.

    Some of ours are: Software Licensing (fixed in 3.7), Recurring (also fixed), Simple Shipping (not fixed yet), Purchase Limit (fixed in 1.2.20) and All Access (fixed in 1.1.5).

    We are scheduled to remove the hooks completely in 3.1 so the notices are added to give developers time to fix their code if they are using it in their extensions.

    Thread Starter Stonehenge Creations

    (@duisterdenhaag)

    I always have my debugging enabled.

    The logs I was talking about are the posts with post type ‘edd_log’.

    Plugin Support Mihai Joldis

    (@misulicus)

    Hey @duisterdenhaag

    In version 3.0 most of the logs to different tables (custom tables). I believe that any posts which are edd_log (the base CPT) will be migrated to the new custom tables. Software Licensing, and possibly other extensions, register their own CPT for logs, such as license activations, etc (edd_license_log), and those will not be touched as part of the EDD core migration to 3.0.

    Some will still remain as custom post types (edd_log) for example the license activation logs from our Software Licensing extension, at least for the time being.

    Thread Starter Stonehenge Creations

    (@duisterdenhaag)

    Okay, thank you.
    It still does not solve the immense increase in the current post count… The bigger the database the longer a query takes.

    Correct me if I am wrong, but your answer does not tell me if an “do not log everything” option is included.

    What is the expected release date for 3.0?

    Plugin Support Mihai Joldis

    (@misulicus)

    There is no setting to not log data in the plugin as some logs are required for stats and other functionality like for example activations inside Software Licensing extension.

    We don’t have a set date for the final release but at the moment version 3.0 is in Beta 1 phase: https://easydigitaldownloads.com/development/2021/02/16/edd-3-0-beta1/

    Thread Starter Stonehenge Creations

    (@duisterdenhaag)

    You make it sound as if every log EED makes is crucial, which most are not.

    If a customer downloads the purchased file once, two log entries are created. One of them completely empty. Really no info at all.. Two unwanted posts extra.

    Every EED API call (for example) products is logged, again as a new post. If have absolutely no need to have those calls logged..

    Every change a customer makes in his/her details is logged and each change (even if done in one submit) get its own new post log entry…

    License activations, deactivations, registered sites, reminder emails, etc. are indeed useful, just like payment statutes. Except the first log entry is always “Payment status changed from to Completed”.

    Payment logs are the only type that use wp_comment_type() which is a much more pleasant way of logging compared to new posts, in my opinion.

    Since there is not a single option in the EDD settings to give users control over their post count and what they want/need to log, if have disabled all EDD Free logs with this snippet:

    add_filter( 'edd_log_types', function() {
      return array();
    }, 1, 1 );

    This still logs the payment logs (comment type) as well as the license logs.

Viewing 8 replies - 1 through 8 (of 8 total)
  • You must be logged in to reply to this topic.