Custom AMP Theme

My theme requires the official amp plugin, previously I used functions to exclude the core WordPress scripts etc.

Can you elaborate? Are you referring to the scripts that your theme is enqueueing? You’re saying that you don’t need to bother with checking whether an AMP page is being served when the AMP plugin is active because the AMP plugin will automatically strip out the scripts? This is true, but it is not the ideal. When you have the AMP plugin’s Developer Tools enabled, it will warn that these scripts were removed, as usually they are being enqueued for a reason and their removal means the user should manually check to see if the functionality is broken. If nothing is broken, the user can mark the validation errors caused by the removed markup as “reviewed”. But the ideal is that the validation error not be caused in the first place.

Therefore, you should always check if an AMP page is being served and conditionally enqueue if it is not an AMP page. For example:

add_action( 'wp_enqueue_scripts', function () {
	if ( function_exists( 'is_amp_endpoint' ) && is_amp_endpoint() ) {
		return;
	}

	wp_enqueue_script( 'my-script' );
} );

We require themes to not emit any validation errors to be featured on the AMP Themes ecosystem page.

• This reply was modified 3 years, 1 month ago by Weston Ruter. Reason: Fix logic inversion

Okay so the best thing to do if I would like to publish a full amp theme to the theme repo to exclude all WordPress scripts, styles, emojies, manually, so it works without the amp plugin, and then recommend it. It just seemed unnecessarily with this plugin installed, as some of my functions will run and do nothing as this plugin will overwrite everything anyway.

I’m not entirely sure what you mean here. What will be overridden?

Note that even though a site may be using an AMP-compatible theme, there may be pages that they don’t want to be served as AMP. Maybe there is a shopping cart page which they want to disable AMP on, for example. Some sites may only want AMP enabled for the Singular template, and leave AMP off for homepage and archive templates. Other users may want to use Transitional mode to have AMP and non-AMP available for all pages. In these cases, a theme needs to work even when the AMP plugin is not processing the page.

Please note that this is going to be made much easier for you later this year with the arrival of Bento AMP: https://blog.amp.dev/2021/01/28/bento/

You’ll be able to bundle AMP component scripts with your theme, like amp-sidebar, and use them on non-AMP pages, even when the AMP plugin is not running. Then we’ll make sure that the AMP plugin respects those scripts and automatically converts them into their CDN equivalents on valid AMP pages, so you won’t have to do anything. Once that happens, the intention is that you’ll be able to write only one version of the interactive features of your theme and have it work in AMP and non-AMP alike.