Support » Plugin: GDPR Personal Data Reports » CSS needs tweaking

  • Resolved nathanwright

    (@nathanwright)


    Hi Sean

    I have just looked at your CSS for the plugin as I noticed that when it was enabled it screws up the BeTheme theme and I have found that you do not prefix any of your CSS with your own reference and have somewhat generic names like “.wrap” which screws up the BeTheme and probably other themes as this is a very commonly used name in themes.

    Can I suggest that you prefix all your CSS names with the name of your plugin as this will minimise the chance of your plugin messing things up and other plugins messing things up with your plugin. It also makes it much easier to debug CSS issues and tweaking the look of the output of your plugin.

    Also, it would be helpful if you added classes and/or ids to the HTML e.g. H3 so that the output can be styled easier as at the moment it is a bit of a fudge to try and do so as it is.

    Would also be nice (maybe in the Pro version) to be able to customise the text that is displayed in the plugin and the email and to turn off things like the H3 header etc so that the plugin can blend with existing sites.

    Best wishes

    Nathan

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author willowsconsulting

    (@willowsconsulting)

    Hi Nathan,

    that is a very helpful suggestion, we will add prefixes to CSS and publish the updated version as soon as possible.

    Thanks,
    Wojtek

    Plugin Author willowsconsulting

    (@willowsconsulting)

    Hi Nathan,

    this is now updated, all classes are prefixed.

    Thanks,
    Wojtek

    Hi Wojtek

    Thats fixed the issues with it conflicting with themes that were using the same css class names but I notice that you have not added any additional class or id to things like H3 etc as you can see from the HTML your plugin produces. It would also be useful if your plugin added an id to the wrapping DIV so that things can be tweaked with CSS as at the moment this is not possible (not easily anyway).

    Cheers

    Nathan

    <div><div><h3 class="">GDPR Request</h3></div>
    			<div class="gdprpdr_entry-content"><p class="">To request a GDPR report please submit your email address below. We will email you a confirmation link to verify
    			you are the owner of the account.</p>
    			<form action="https://www.gdprhelp.je/gdpr-personal-data-report-request/?new_gdpr_request=1" method="post">
    				<input type="email" name="email" placehoder="E-mail Address" required=""><br>
    
    				<input type="checkbox" name="gdpr_request_form_checkbox" required="">
    				<label for="gdpr_request_form_checkbox">I consent to having Jaz'ing Up GDPR! collect my email, IP address and browser request details for the purpose of generating the personal data report (to learn more about our privacy policy please visit our privacy policy statement).</label>
    
    				<input type="submit" class="button submit gdprpdr_submit-button" value="Submit">
    			</form></div></div>
    Plugin Author willowsconsulting

    (@willowsconsulting)

    Hi Nathan,

    for the GDPR forms you can pass your existing CSS classes to style the header, description text and the button by passing them as parameters in the shortcode, like in the example below:

    [gdpr-forget-me-request-form text_classes=”class1 class2″ header_classes=”class3″ button_classes=”class4″]

    Is that what you mean, or do you need more flexibility with this?

    There is no option to easily add styling to the email at the moment other then editing the mail partials directly. A lot of the CSS in the emails need to be inlined to display correctly in some email clients, so this is a bit more complicated then doing it for the forms.
    I will add this to our list of requested features and we will look into it as soon as possible.

    Thanks,
    Wojtek

    Hi Wojtek

    Your suggestion is much more than I was suggesting re passing classes via shortcode and I think is more than is needed.

    All I was suggesting is that you add a class to the div wrapper as I might not want to style h3 across the whole page but have h3 for your part different. At present you have:

    <div><div><h3 class="">GDPR Request</h3></div>

    I would prefer:

    <div class="gdpr_personal_data_reports_wrapper"><div><h3 class="">GDPR Request</h3></div>

    By adding the above it is then possible to specifically customise anything inside your part without effecting other parts of the page.

    Nathan

    Plugin Author willowsconsulting

    (@willowsconsulting)

    Got it, adding a wrapper class for the outer div is not a problem. It’s done now.

    Thanks,
    Wojtek

    Perfect, exactly what was needed so now the content can be made to match the rest of a site to make it a perfect fit.

    I am looking forward to seeing the Pro version.

    Best wishes

    Nathan

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘CSS needs tweaking’ is closed to new replies.