Convert inline styles to included CSS file or merge with theme

  • Gal Baras

    (@galbaras)


    9 years, 3 months ago

    The plugin outputs some styles into the HTML page. This is incompatible with minification and is flagged by Google Page Speed as an issue.

    It would be better to include (using wp_enqueue_style) all the styles as a separate CSS file and/or to provide the option to stop plugin styles form being output.

    Theme developers can then copy the styles into the theme’s stylesheet and then disable them from being written inline using wp_dequeue_style or by selecting the “disable CSS” setting.

    https://wordpress.org/plugins/fluid-video-embeds/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author jamie3d

    (@jamie3d)

    9 years, 2 months ago

    I can see how this is a problem.

    I did it this way because I didn’t want to include an additional stylesheet for 6 CSS rules. That seemed like a waste of a http request to me.

    There’s also the issue of media queries. If the media query is customizable (which it is), then how could I maintain this and use a linked stylesheet at the same time? Inline styles are a no-go at that point. While your issue is legitimate, I’m not entirely sure of the right way to handle this.

    CarolineElisa

    (@carolineelisa)

    9 years, 2 months ago

    I agree this is an issue.

    It would be nice to at least have the option of disabling the embedded CSS, although still displaying it in the backend so that it could be copied and pasted it into the theme.

    Plugin Author jamie3d

    (@jamie3d)

    9 years ago

    I have added an option that allows you to disable the <style> tag output, and also provides the generated CSS for you to copy and paste into your theme.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Convert inline styles to included CSS file or merge with theme’ is closed to new replies.