WordPress.org

Support

Support » Plugins and Hacks » Better WordPress Minify » conflict with Use Google Libraries 1.5.2?

conflict with Use Google Libraries 1.5.2?

Viewing 11 replies - 1 through 11 (of 11 total)
  • Plugin Author Khang Minh

    @oddoneout

    Hmm never had a problem with that plugin before. I will check it, thank you.

    I’ve never had problems either. I checked the 1.5.2 changes on the changelog and there seem to be changes that may have affected things. I would dig into it myself, but no time – thought I would let people know anyway.

    Starting with WordPress 3.5, the script loader supports protocol-relative URLS, to more easily support SSL. With 1.5.2 I added support for this to Use Google Libraries as well.

    At a guess I’d say that BWM’s is_local returns true for these, when it should return false. WordPress’s own registrations for some older scripts work this way now.

    Update: It seems this is a “limitation” of php’s parse_url and won’t be fixed in php, so it may need to be handled directly.

    Thanks Jason! Will pass this on to the BWM author.

    OK, I got the wrong thread 🙂 I’ll leave this open for discussion here.

    I’m seeing a conflict, too, after upgrading.

    Plugin Author Khang Minh

    @oddoneout

    This will be fixed in the next version.

    Great news. Any idea when the next version may land?

    FYI: this is still not fixed.

    The test for protocol-relative URLS is incorrect.

    It seems to be checking for URLSs that start ‘://’ but protocol-relative URLs start with ‘//’.

    You can see this is WordPress core inside wp-includes/script-loader.php:

    $scripts->add( 'prototype', '//ajax.googleapis.com/ajax/libs/prototype/1.7.1.0/prototype.js', array(), '1.7.1');

    Hi Jason or oddoneout,

    Any news on this topic? I am experiencing the same conflict between BWM and libraries.

    Best Anders

    Plugin Author Khang Minh

    @oddoneout

    1.3.0 will fix this issue, you can follow dev update here: https://github.com/OddOneOut/Better-WordPress-Minify

Viewing 11 replies - 1 through 11 (of 11 total)
  • The topic ‘conflict with Use Google Libraries 1.5.2?’ is closed to new replies.
Skip to toolbar