Support » Plugin: Off-Canvas Sidebars & Menus (Slidebars) » Compatibility with Twenty Seventeen

  • Resolved rfortin

    (@rfortin)


    Issues with the front page which contains fixed images. Also the scroll bar on the front page doesn’t allow dragging, only mouse wheel scroll. I’d love it if your plugin could work with twenty seventeen. Let me know.

    Raymond

Viewing 15 replies - 1 through 15 (of 22 total)
  • Plugin Author Jory Hogeveen

    (@keraweb)

    Hi @rfortin,

    I just tested twenty seventeen and didn’t find issues with the theme!
    Could you send me an example link of your site with some more information about what isn’t working?

    Also, as I’m testing with the latest dev version, please check GitHub.
    https://github.com/JoryHogeveen/off-canvas-sidebars/pull/25
    I’m quite busy but hope to release a major update this year (v0.4) which also enables the use of shortcodes etc. But the most major thing for this update is the “legacy mode” which uses regular (older) CSS instead of CSS3. This will support fixed elements etc. as well.

    Let me know and have a nice day!
    Thanks, Jory

    Thread Starter rfortin

    (@rfortin)

    Hi Jory. My bare bones test site is http://www.medusa.feedmestories.com

    The main issue is that my pages, which were added as front page sections under appearance -> customize -> theme options, do not appear correctly. These sections should display the fixed featured images as page content slides. See the website for an expanded list of issues.

    I tried following your simple theme setup as best as I could (and I’ve double checked and re-added the code snippets several times). Please let me know if there’s anything I can do.

    Raymond

    Plugin Author Jory Hogeveen

    (@keraweb)

    Hi @rfortin,

    There is a known problem with fixed elements.
    This plugin uses the “Slidebars” jQuery library which (in core) doesn’t support fixed elements within the site container. (Same goes for anchor links).
    The latest PR on GitHub should fix this but it’s not 100% ready (finetuning etc etc).
    https://github.com/JoryHogeveen/off-canvas-sidebars/pull/25

    Your theme setup was correct as far as I can see in the source code!

    Please try to update the plugin to the latest version on GitHub and let me know if it works for you!

    Thanks, Jory

    Thread Starter rfortin

    (@rfortin)

    I’ve implemented the latest files and it’s almost perfect with the legacy css solution.

    However, the header image does not initially appear correctly when the page is refreshed, as in, the image looks zoomed in (from developer tools it looks like the image loads with incorrect height). Once you scroll down past the image and scroll back up, the image then appears correctly.

    Let me know if you can reproduce the issue with my test site.

    Thanks for your hard work on the plugin,

    Raymond

    Plugin Author Jory Hogeveen

    (@keraweb)

    Sorry I didn’t reply earlier, these last days of a year are one of my most busy days.

    Hmmm, I see what you mean, Its only in the very first moment.
    I can’t realy find what could be causing this other than that the page is just still loading.

    Are you sure this didn’t happen before you used off canvas sidebars?

    Thread Starter rfortin

    (@rfortin)

    The page loads perfectly when the plugin is disabled. When the plugin is enabled, the header image will either load slowly in the first moment (as you saw) or remain disproportionately enlarged (It loads as 1264 × 3728 pixels instead of 1264 × 810). When it is stuck in this enlarged state, scrolling down past the header and then scrolling back up returns the image to its proper size.

    Let me know if you can see the enlarged header image. Sometimes it only happens after a few page refreshes.

    Plugin Author Jory Hogeveen

    (@keraweb)

    Hi @rfortin

    I’ve been testing locally but cannot reproduce this issue.
    What plugins/settings and/or other modifications have you done?

    Thread Starter rfortin

    (@rfortin)

    Hi Jory.

    No plugins or modifications. However the issues might be browser related. I tried internet explorer and there was no issue with the plugin. Looked really great. However, in Chrome (which I’ve been using until this point) the issue persists, as with Firefox. Safari is moderately better but not perfect either.

    Let me know if this helps and whether you can reproduce the issues in these browsers.

    Plugin Author Jory Hogeveen

    (@keraweb)

    Hi @rfortin

    Found how to reproduce the issue and I think I fixed the problem!
    The thing with the legacy CSS was that is relied on JS to do the ckeck, so this CSS get’s activated when JS is fully loaded. This will cause a small glitch in the beginning.

    I’ve made a commit to the dev branche on GitHub that will add the required classes to the body tag when the page is rendered so the CSS is instantly applied.

    Please check the latest code and let me know if it helps!
    https://github.com/JoryHogeveen/off-canvas-sidebars/pull/25

    Also, please keep in mind that this PR is not 100% ready (v0.4 will be a very big update).
    If the current state works for you, great!
    If you find any issues, let me know!

    Regards, Jory

    • This reply was modified 4 years, 9 months ago by Jory Hogeveen.

    Hello, I have tried the seventeen theme which works fine except a compatibility problem with Internet Explorer: when scrolling down the homepage, it is flickering. Can you please help ? Thanks

    Plugin Author Jory Hogeveen

    (@keraweb)

    Hi @snaetilux

    Sure! Have you tried the latest dev version from github?
    And what version of IE are you using?

    Hello Jory, thanks for getting in touch. No, I don’t know enough to install this dev version, I think. How can I do that ? IE 11 is giving those lagging visual effect. I can send you the devoppment website by mail to have a look if you want to see it ?

    Plugin Author Jory Hogeveen

    (@keraweb)

    Hi @snaetilux,

    I’m 99% sure the dev version will fix this as it sounds like the same problem.
    You can install a dev version by following the manual installation steps from WordPress

    1. Download the plugin in .zip format (in your case, you can download it from here: https://github.com/JoryHogeveen/off-canvas-sidebars/tree/dev)

    2a. Upload the .zip file in WP Admin (new plugin)
    2b. Or Upload the extracted file with FTP to the wp-content/plugins folder

    It should overwrite the existing code.
    Here is a simple tutorial: https://www.youtube.com/watch?v=jl_S0DQMnXg

    Hi Jory, thanks again. I’ve installed it. What should I do ? I go on settings, I’ve enabled what seems ok to me, but don’t know what to do with this plugin ?

    Plugin Author Jory Hogeveen

    (@keraweb)

    Hi @snaetilux

    I don’t understand your question actually. Are you asking for help with the main setup?
    If so, I think it’s better not to discuss that here. This is for bug reports, not general setup help.
    Please go to my Slack channel for general help: https://keraweb.slack.com/archives/plugin-ocs

    • This reply was modified 4 years, 8 months ago by Jory Hogeveen.
Viewing 15 replies - 1 through 15 (of 22 total)
  • The topic ‘Compatibility with Twenty Seventeen’ is closed to new replies.