@benjaminloeffel Thanks for the question! We added automated scanning for PHP 7.0+, which should check for problems on 8.0 and 8.1 and no issues were found. In addition, we also manually checked on both 8.0 and 8.1 and didn’t see any issues, so it should be compatible with both. If you notice issues though, let us know and we’d be happy to prioritize fixes for that. Thanks!
Thread Starter
Ben
(@benjaminloeffel)
@dkotter Great, I will confidently proceed with the update and let you know in case any issues arise.
Thanks a lot for your quick help and feedback!
@dkotter
I’m just making sure that we won’t have issues, VIP Engineers will be looking over the plugin before it hits our production server and we will be smoke testing it.
When you say you have manually checked against 8.0 and 8.1, I’m assuming that means you tested the plugin on those php versions?
Here is what came up in WP VIP Bot.
Function libxml_disable_entity_loader() is deprecated since PHP 8.0 (PHPCompatibility.FunctionUse.RemovedFunctions.libxml_disable_entity_loaderDeprecated).
-
This reply was modified 1 year, 6 months ago by
midikris.
-
This reply was modified 1 year, 6 months ago by midikris.
-
This reply was modified 1 year, 6 months ago by midikris.
@midikris Yes, we did test it against PHP 8 (don’t recall if that was just 8.0 or if it included 8.1) and we have automated code scanning for 8.0+. I will say that the testing was around breaking changes though, not deprecation notices, so I’m not surprised there. We will look to fix all of those up though it is a lower priority as it won’t immediately cause any problems.
I know VIP has reviewed this plugin before but let us know if they flag anything that needs fixing and we can look to take care of that. Thanks!
@dkotter Thanks for the reply, we’ll push it through VIP review. Thanks for a great plugin.
