Clicked checkbox for creating/linking post didnt work

  • bmogged

    (@bmogged)


    5 years ago

    Hello,

    I recently did a large scale update of our WordPress site and when I updated the site the plug in wouldn’t open the settings on linking new posts if I click the checkbox.

    After rummage through the code it looks like it is using attr to check if the checkbox is checked which seems to be bringing a false result. I switched to

    if(jQuery(this).prop(‘checked’)) {

    in the two places in the index.php and the code works again.

    This seems to be more a jQuery side effect than anything else. I can reproduce the problem with older code and new.

    • This topic was modified 5 years ago by bmogged.
Viewing 13 replies - 1 through 13 (of 13 total)
  • Plugin Author Robin W

    (@robin-w)

    5 years ago

    thanks for posting this – let me take a look

    Virtualtopia

    (@virtualtopia)

    5 years ago

    It would be great to get this sorted. To make this plugin work I have been forced to use Enable jQuery Migrate Helper plugin which is used to support outdated plugins and themes by using older jQuery code. And it never works first time upon publishing a post. But if I update multiple times, eventually a topic in BBPress is created.

    Plugin Author Robin W

    (@robin-w)

    4 years, 12 months ago

    I will be looking at this during this week 🙂

    Plugin Author Robin W

    (@robin-w)

    4 years, 12 months ago

    @bmogged – to save me scrolling through code, on what lines did you do these changes ?

    Plugin Author Robin W

    (@robin-w)

    4 years, 12 months ago

    @bmogged

    is it these two instances?

    if(jQuery(this).attr('checked')) {

    Thread Starter bmogged

    (@bmogged)

    4 years, 12 months ago

    Sorry was a bit busy.

    Yes those are the two lines made this work.

    Plugin Author Robin W

    (@robin-w)

    4 years, 12 months ago

    great – I’ll release a new version later today

    Plugin Author Robin W

    (@robin-w)

    4 years, 12 months ago

    Version 1.9.3 just released should fix, please let me know

    Virtualtopia

    (@virtualtopia)

    4 years, 12 months ago

    It broke my site. Renamed plugin using FTP. Site back. Plugin will not activate.
    Message read:
    “Plugin could not be activated because it triggered a fatal error.”

    Virtualtopia

    (@virtualtopia)

    4 years, 12 months ago

    I copied the code from the previous version 1.9.2, then made those 2 changes myself (.attr to .prop) and it works for me. Version 1.9.3 has a problem on line 72 I think it was. It was about the topic slug. BBTS.

    Plugin Author Robin W

    (@robin-w)

    4 years, 12 months ago

    thanks, syntax error introduced – really hard to be one man developer and tester – sorry !!

    Hopefully fixed in 1.9.4 – can you test for me please ?

    Virtualtopia

    (@virtualtopia)

    4 years, 12 months ago

    Yes that fixed it. It also got rid of an error message appearing at the top of the CMS.
    I tested it and it creates the associated topic. But not perfect. It works without me using the jQuery Manager for WordPress plugin which I am very happy about. But the topic is not created when publishing the post. Only when I update the post after that. But the core functionality is there and my site is back. I appreciate your time with this. I would be happy to help out with this plugin if your time is limited. I could test out any changes for you as this helps me because I have 2 websites that use this plugin.

    Plugin Author Robin W

    (@robin-w)

    4 years, 12 months ago

    let me take anther look at that when I get a mo, and yes any help in testing is much appreciated 🙂

Viewing 13 replies - 1 through 13 (of 13 total)

The topic ‘Clicked checkbox for creating/linking post didnt work’ is closed to new replies.