Chunked Downloads Not Working | WordPress.org

Resolved s0nata
(@s0nata)

3 years, 8 months ago

I’ve noticed for a while that larger PDF file downloads on our site fail with messages like “Couldn’t download – Network issue” in the browser despite returning an HTTP 200 status code. Today I think I finally figured out the issue.

In the latest version of the plugin, in the DownloadHandler.php file, the function readfile_chunked at line 667 has three parameters: $file, $retbytes = true, and $range = false. However, it is called at line 554 in the same file with: this->readfile_chunked( $file_path, $range). The $range variable in the call is being assigned to the $retbytes parameter instead. I’ve fixed this by changing my call to: this->readfile_chunked( $file_path, true, $range) instead.

Hopefully others find this useful and maybe the plugin can be updated with the fix.

Cheers!

Viewing 3 replies - 1 through 3 (of 3 total)

Harish Chouhan
(@hchouhan)

3 years, 7 months ago

Hey @s0nata,

Thanks for reaching out to us.

I have created a ticket for this at https://github.com/download-monitor/download-monitor/issues/638.

I can’t promise a timeline but I will notify you if there are any updates from our end.

cvj1987
(@cvj1987)

3 years, 6 months ago

Hi @hchouhan,
my downloads stopped working after the switch to a newer server. Turns out, the problem is the code for the chunked downloads, too.

In my case $_SERVER[‘HTTP_RANGE’] contains a range_end bigger than $version->get_filesize() – 1 now and the download fails:
curl: (92) HTTP/2 stream 0 was not closed cleanly: INTERNAL_ERROR (err 2)

I added this to fix it:
if ($range_end > $version->get_filesize() – 1) {
$range_end = $version->get_filesize() – 1;
}

The line:
header( “HTTP/1.1 206 Partial Content” );
Is strange to me, too. I am using HTTP/2. Still works though.

Harish Chouhan
(@hchouhan)

3 years, 5 months ago

Hey @cvj1987,

I have created a ticket at https://github.com/download-monitor/download-monitor/issues/645.

While I cannot promise any time estimate now, once we have any updates, we will notify you.

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘Chunked Downloads Not Working’ is closed to new replies.

In: Plugins
3 replies
3 participants
Last reply from: Harish Chouhan
Last activity: 3 years, 5 months ago
Status: resolved