Hi,
Thanks for your feedback. The plugin doesn’t use Ajax. It uses JavaScript (mainly ReactJS) and REST API endpoints.
For this first version, the plugin provides a menu to reach a member’s Media Library. If I can see an interest to list a member’s public media, I’m not sure the Member’s Media Library should be available for someone else than the owner of it. Having a new tab using what’s in place for the community media directory seems safer to me.
I’d be very interested to see a Pull Request about it here: https://github.com/buddypress/bp-attachments
You are misunderstanding me
Firstly when I say Ajax I mean as a description of a general pattern wherebye functionality is done without a full page refresh
As a general rule good practice is that when this pattern is used that you can access this functionality through a url (addressability is one of the strengths of the web).
Specifically in this case I’d like to link directly to the the public folder of the user from a menu (this will make discovery of the functionslity much easier).
I can link to the general functionality eg
/members/me/attachments/
but I can’t link to specific folders e.g.
/members/me/attachments/public/
I do realise is not the only example of this in buddypress but it is a new one.
Ok, just like WordPress, we write BuddyPress. Thanks for sharing your concern about how should behave the plugin.
I think you are being sarcastic, please don’t I am trying to help improve things
When you say WordPress already does things this way, you are partially correct but the pattern is very rare and mainly Gutenberg. But Gutenberg tries to update the url on get requests so that key functionality is addressable. So I’m not saying don’t use react, just use it in a way compatible with how the web and users expect things to work
For example from a users point of view the current approach means that the back button does not work as a user would expect. Eg if I click on the public folder, I would normally expect to be able to use the back button to return to home but instead I leave the whole component.
-
This reply was modified 1 year, 1 month ago by
shawfactor.
I’m not being sarcastic, I’m not English so I guess I made a mistake when translating. What I wanted to say is we use a capital B and a capital P to write BuddyPress, just like we use a capital W and a capital P to write WordPress.
I understood your point, we’re doing our best to improve BuddyPress and its Add-ons and are fully open to code contribution.
Okay my misunderstanding and I want to reiterate my thanks for the work the whole contributor group does. The new functionality is great (although it could be even better)
I’m self taught so I’ve yet to master the contribution process, but I will.
although I figure if I can get my startup to the next stage thst will be far bigger for buddypress than any code I can write.
