Calculated Field Type (regression)

  • chrisok_oz

    (@chrisok_oz)


    7 years, 7 months ago

    Hey there,

    Just wanted to make a suggestion for the new updates made today, in relation to a previous post: https://wordpress.org/support/topic/get-fields-calculated-type-rather-than-direct-access/.

    As of the new version and the changeover to GF Addon structure, the field type is once again accessed directly from the property, rather than the calculated method. Just wanted to make the suggestion that it be reverted to the method in the following locations:

    gravity-forms-list-field-datepicker-addon.php:73
    gravity-forms-list-field-datepicker-addon.php:114
    gravity-forms-list-field-datepicker-plugin.php:102
    gravity-forms-list-field-datepicker-plugin.php:129
    gravity-forms-list-field-datepicker-plugin.php:624

    Also, I noticed the following line (gravity-forms-list-field-datepicker-addon.php:133):

    if ( true == array( $this, 'requires_scripts' ) ) {

    which looks like it might be a typo from copy pasting the callback reference of this method – should this instead be:

    if ( true == $this->requires_scripts ) {

    ?

Viewing 2 replies - 1 through 2 (of 2 total)
  • Thread Starter chrisok_oz

    (@chrisok_oz)

    7 years, 7 months ago

    Derp – I say ‘New Updates made Today’ but actually should say ‘Made recently (which I installed today)’.

    Plugin Author ovann86

    (@ovann86)

    7 years, 2 months ago

    Hey – Just getting to these now. Thanks.

    I’ll eventually keep a copy on github – I’ll let you know when I do in case you’re interested in contributing.

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Calculated Field Type (regression)’ is closed to new replies.