[Resolved] Bugfix for Dynamic Height
This is a great plugin—well done. I began using it a couple of months ago in a site I’m developing. The project got postponed and upon resuming it, I realized there was a difference in the local version of the website and the remote. The remote had been updated to the more recent version of the plugin, the the local hadn’t.
The difference was that there was no longer dynamic height adjustment of the container div. After looking at the updates, I realized that you’d updated to Cycle2. So I went on his website and looked through the API and realized that the issue is with one
"data-"metatag on the container div.
"data-cycletwo-auto-height"is set to
"calc"which calculates and sets the container height to the tallest containing slide. Previously, the plugin had the behavior of setting that to “container” (probably the original Cycle’s default behavior). Anyways, I recognize the need for you to make a judgement call here — I resolved it for myself on line 413 of testimonial-rotator.php (but will now have to instruct client to not update).
So I updated:
data-cycletwo-auto-height=\"calc\"to now be
data-cycletwo-auto-height=\"container\"on line 413.
My suggestion is perhaps to make this a setting per testimonial slider. I don’t know the amount of work that might take, so I understand you not doing it either.
Either way, thanks for making such a great plugin. Quite happy with it. You can see it in action at http://watershed.ccmservers.com for the time being.
- The topic ‘[Resolved] Bugfix for Dynamic Height’ is closed to new replies.