Support » Plugin: Seriously Simple Podcasting » Bug with WP 3.6 version check

  • ResolvedModerator Pippin Williamson

    (@mordauk)


    I’ve just found a bug when using the plugin with WP 3.6.1 and greater. In the audio_player() member function, the check for WP 3.6 and greater is currently:

    if( $wp_version && $wp_version == '3.6' ) {

    This is so that the wp_audio_shortcode() can be used instead of building the output manually. The problem, however, is that this only works if on WP 3.6, since it is using ==.

    The check should be updated to:

    if( $wp_version && $wp_version >= '3.6' ) {

    http://wordpress.org/plugins/seriously-simple-podcasting/

Viewing 5 replies - 1 through 5 (of 5 total)
  • Or better yet, use PHP’s version_compare().

    Moderator Pippin Williamson

    (@mordauk)

    Either would be fine.

    Plugin Contributor Hugh Lashbrooke

    (@hlashbrooke)

    Thanks for that – someone actually pointed that out in a different thread here and I’ve made the fix already using version_compare() (it was a stupid mistake on my part to leave that out). I’m just working on one other fix before I release the next version.

    I should have this out in the next day or two – in the mean time I suggest you do the fix manually in the plugin. I’ll update here once it has been released.

    Plugin Contributor Hugh Lashbrooke

    (@hlashbrooke)

    Looks like I found a quick way to fix the other bug I mentioned and I’ve just published this release sooner than I thought I would. v1.7.3 should be available now with a proper version comparison: http://wordpress.org/plugins/seriously-simple-podcasting/changelog/.

    Thanks for pointing this out!

    Moderator Pippin Williamson

    (@mordauk)

    Great!

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Bug with WP 3.6 version check’ is closed to new replies.