Bug when using numeric terms for event categories

  • Resolved transom

    (@transom)


    9 years, 8 months ago

    For version 3.7 (running only twentyfourteen and TEC)
    My usage has years as an event category(2014, 2013, etc). When listing events for the terms (‘/events/category/2014’) No results are found. But using a non-numeric term works correctly.

    I isolated the issue to /lib/tribe-event-query-class.php around line # 274 where the code tests for “is_numeric” on the term to set the field to ID or slug. I contend that this should be “is_int” to work correctly (but I am not sure why it is even needed since the tax_query is already setup correctly at this point.)

    This ends up re-setting the tax_query where the query must match both the ID and the slug as == the numeric term – a case that is very, very unlikely to happen.

    https://wordpress.org/plugins/the-events-calendar/

Viewing 2 replies - 1 through 2 (of 2 total)
  • Brook

    (@brook-tribe)

    9 years, 8 months ago

    Howdy transom,

    The Events Calendar requires non numeric category titles. Instead of 2014, what about Twenty Fourteen?

    Juuuuuust kidding. Thank you for pointing this out. I agree, something like is_int() is much better suited for the task. I am submitting a ticket for a developer to see about a solution.

    By the way, The Events Calendar is open source. If you are diving into the code and are interested in ever submitting a patch, checkout our git repository: https://github.com/moderntribe/the-events-calendar

    Thanks again!

    – Brook

    Plugin Contributor leahkoerper

    (@leahkoerper)

    9 years, 7 months ago

    Hi there,

    Thanks for bringing this issue to our attention. We weren’t able to get to it for our upcoming 3.8 release, but it is still very much on the radar. We hope to have it fixed in an upcoming release, and we will do our best to keep you posted on our progress. Thanks for your patience and support!

    Best,
    Leah
    and the team at Modern Tribe

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Bug when using numeric terms for event categories’ is closed to new replies.