Bug Report (re: Excerpt), tables disrupt layout if used

  • doncullen

    (@doncullen)


    9 years, 2 months ago

    Haven’t taken a look at the code, but fairly sure it exists. When it crops the text, I suspect it doesn’t check to see if it’s cropping in middle of a html tag. So if it happens to crop in the middle of a table cell tag, it breaks the entire webpage’s layout. Being a coder, I can appreciate the challenge of determine whether you’re about to break a page, and adjusting accordingly, and volunteer time working on this plugin.

    So instead, I have a suggestion for you to consider: perhaps add support for an option on each announcement for it to cut the text at a specific number rather than applying it to all announcements enmasse. Even better would be if once you add support for this option, perhaps within the announcement editor below the text editor, there was a div box containing the code of the text, with the place where it’d be snipped at highlighted. This way, people with basic working knowledge of code can quickly determine why it breaks and adjust the number of characters to snip at for that announcement to minimize breakage.

    Yes, I know. Using tables are a big no-no. I should use DIV’s instead. I do use DIV’s. I got lazy. Sue me. =P

    Not your problem, but just wanted to mention it.

    Another bug I wanted to report is: it appears that if an announcement has a table in it (or at least it does in my theme [SaladMag]), it appears that the table will display above the dropdown menu of that particular theme. Makes me think it has something to do with the z-index. Either that or there’s absolute positioning inside the menu. I’d have to dig into the code to determine the cause, but since it’s not a major problem, I’ll just leave it as is and move on. If people complain, I’ll tell them it’s a feature. 😉

    I have an unrelated suggestion: allow me to have each announcement on the timeline be spaced apart by percentages rather than via fixed pixels. If it’s got to be pixels, then at least let me decide how far to space them. Right now they’re so far apart that it’s almost silly. Again, not a dealbreaker.

    If you’d like to see what I’m talking about above, feel free to take a peek at: http://tdi.doncullen.net/about-tdi/history-of-tdi/

    I realize you charge for support, and that this matter isn’t really your problem since I’m not a paid customer. Just figured I’d mention it if you didn’t already know.

    Thanks for putting in the time to make this plugin, and for making this available to the public.

    https://wordpress.org/plugins/timeline-express/

Viewing 1 replies (of 1 total)
  • Plugin Author Evan Herman

    (@eherman24)

    9 years, 2 months ago

    Hi Doncullen,

    Sorry for the long delay in responses. I was actually travelling abroad and had very limited access to internet or even a phone.

    I had actually noticed this issue in a previous release, which is why I re-wrote the custom excerpt function in the latest release.

    One of the other issues that I am facing is the ability to decide the spacing between announcement globally. What works for one users theme may not work for another, so I will certainly look into building in a setting to alter the distance between announcements based on percentages rather than a set -3.5em.

    Thank you for taking the time to write a well thought out response here with some issues you are facing. I will look into these issues as soon as possible and get around to pushing out a release as time permits.

    I will keep this thread open and comment back here as I make progress moving forward.

    Thanks,
    Evan

Viewing 1 replies (of 1 total)
  • The topic ‘Bug Report (re: Excerpt), tables disrupt layout if used’ is closed to new replies.