• Resolved codingninja

    (@codingninja)


    Hi, I just want the creators of this plugin to know that I really like the plugin, but there is a bug, that may be fixed for the next version release. I found the bug through an HTML validator.

    This line:
    $link = sprintf( '<a class="bible-gateway" href="%1$s" onclick="biblegwlinkpop(this.href,\'%2$s\',%3$s,%4$s)"" target="_blank">%5$s</a>', $search, esc_js( $attr['passage'] ),

    The onclick:
    onclick="biblegwlinkpop(this.href,\'%2$s\',%3$s,%4$s)""

    I removed the extra ” and it was fine.

    https://wordpress.org/plugins/biblegateway-links-shortcode/

Viewing 1 replies (of 1 total)
Viewing 1 replies (of 1 total)
  • The topic ‘Bug report: extra quote at the end of onclick event’ is closed to new replies.