BUG – jQuery deregister could cause problem

  • obsidianart

    (@obsidianart)


    10 years, 6 months ago

    Hi,
    I deregisterd jQuery from wordpress to swap with the last version.
    I’m not sure why but in one of the website the plugin crashed saying “jQuery not defined”.
    Could you please change cookie-warning line 54 to
    wp_enqueue_script( ‘cookie-warning’ , plugin_dir_url(__FILE__).’cookiewarning.js’,array(‘jquery’),”, true);

    It seems correct to specify that your plugin depends on jquery and fix the problem. up to you if you want to put a version and put it in the footer

    http://wordpress.org/plugins/cookie-warning/

Viewing 4 replies - 1 through 4 (of 4 total)
  • esmi

    (@esmi)

    10 years, 6 months ago

    I deregisterd jQuery from wordpress to swap with the last version.

    Why? You should never, EVER, de-register core jQuery.

    Thread Starter obsidianart

    (@obsidianart)

    10 years, 6 months ago

    Because I want a different version of jQuery, what’s wrong with that?
    And, if you assume you should not, why do you bother to register it on your plugin?

    esmi

    (@esmi)

    10 years, 6 months ago

    what’s wrong with that?

    You will break other plugins and may stop WordPress itself working correctly.

    Thread Starter obsidianart

    (@obsidianart)

    10 years, 6 months ago

    ok, let’s assume for now you are right, it doesn’t matter. If you want you can write on this documentation page http://codex.wordpress.org/Function_Reference/wp_deregister_script explaining of much they are wrong and deceiving.

    Do you agree that when you include your script you should specify that it depends on jQuery? Can we just agree on that so I don’t have to fork your plugin?

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘BUG – jQuery deregister could cause problem’ is closed to new replies.