Bug in latest version

  • Resolved jeroende

    (@jeroende)


    4 years, 10 months ago

    adrotate-output.php

    Line 779:
    $generated_css = get_option(‘adrotate_group_css’, array()) + $network_css;

    needs to be:
    $generated_css = get_option(‘adrotate_group_css’, array()) . $network_css;

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Arnan de Gans

    (@adegans)

    4 years, 10 months ago

    No, That’s not how you join arrays 😉
    Not a bug.

    • This reply was modified 4 years, 10 months ago by Arnan de Gans.
    Thread Starter jeroende

    (@jeroende)

    4 years, 10 months ago

    It does make it crash here:

    stderr: PHP message: PHP Fatal error: Uncaught Error: Unsupported operand types in …/wp-content/plugins/adrotate-pro/adrotate-output.php:779

    joining arrays is also usualy done with array_merge

    • This reply was modified 4 years, 10 months ago by jeroende.
    Plugin Author Arnan de Gans

    (@adegans)

    4 years, 10 months ago

    I can’t reproduce that error – Try re-saving a group so the CSS is regenerated.
    That probably helps.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Bug in latest version’ is closed to new replies.