• Resolved ockhamdesign

    (@ockhamdesign)


    Steps:

    Go to any page.
    Unload any javascript. That item now turns pink.
    Checkmark “Unload dependency rule and keep the “children” loaded
    Update.

    Now to go any post.
    You will now see that checkmark “Unload dependency rule and keep the “children”
    Even though “Unload On this page” is white. The checkmark for “Unload dependency” is checkmarked. This breaks the post.

    If you un-checkmkark it on the post (JS not unloaded), then it uncheckmarks on the page (JS unloaded) as well which breaks the page.

    • This topic was modified 4 years, 5 months ago by ockhamdesign.
    • This topic was modified 4 years, 5 months ago by ockhamdesign.
Viewing 5 replies - 1 through 5 (of 5 total)
  • Thread Starter ockhamdesign

    (@ockhamdesign)

    Images of the bug:

    https://ibb.co/6ykn8hp – checkmark on 1 page

    https://ibb.co/1XWy4b9 – shows up on all posts

    Plugin Author Gabe Livan

    (@gabelivan)

    @ockhamdesign thanks for letting me know about a potential bug. I’m frankly surprised as this has been tested many times and it shouldn’t take any action if the asset is not unloaded.

    The feature ‘Ignore dependency rule and keep the “children” loaded’ should take effect only if the asset is marked for unloading. I know, it’s confusing that the checkbox is ticked in other pages where the asset is in fact loaded. But it shouldn’t take any effect. If the asset is not marked for unloading (either per page, everywhere, etc.), then by default is loaded anyway.

    I’ll make some proper tests and get back to you. If it’s indeed an issue, it will be fixed and added to the next version.

    Thread Starter ockhamdesign

    (@ockhamdesign)

    It didn’t take effect in 1.1.4.3. This is what I have running on my production server.

    It does in 1.1.4.8 and higher. I’ve been testing this issue on our Test servers.

    • This reply was modified 4 years, 5 months ago by ockhamdesign.
    Plugin Author Gabe Livan

    (@gabelivan)

    @ockhamdesign I’ve been making tests and all worked smoothly, just as it did before. So, I went on a post, unloaded a JS and ticked the checkbox to not unload any of its children. On that post, the parent JS file was unloaded, but its “children” loaded, exactly how it should work.

    Then, I went to a different post and noticed the ‘Ignore dependency rule and keep the “children” loaded’ is checked, which is normal as you have chosen this option to apply IN CASE the parent file is unloaded. However, if the parent file is not unloaded then it loads fine on the second post. Its “children” are also loaded IF they are not marked for unloading.

    I know, the checkbox is showing up (it doesn’t have any effect at all as the asset is already loaded) and it can be confusing to show for loaded JS. In future versions it could be hidden UNTIL you mark the assets for unloading. Once you click “Unload on this page” or other unload rules, then the checkbox would show up.

    Nothing was broken on my tests. In your tests, which of the files are unloaded (when they shouldn’t be unloaded) or loaded (when they should be unloaded)? Perhaps something else is interfering with any console errors you might be getting. Let me know and I’d be happy to check this further!

    Plugin Author Gabe Livan

    (@gabelivan)

    @ockhamdesign this is just a reminder of checking the previous message I posted. Let me know if you still have this issue!

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Bug: Ignore dependency rule’ is closed to new replies.