[bug] if removing /category/, rewrite rules will ignore custom feeds | WordPress.org

Resolved DrLightman
(@drlightman)

7 years, 1 month ago

If one uses the yoast’s /category/ removal and defines custom feeds with add_feed() function, they won’t work for categories becasue the custom feeds name are not being added to specific rewrite rules.

Yoast generated rule for category “mycat”:

[(mycat)/(?:feed/)?(feed|rdf|rss|rss2|atom)/?$] => index.php?category_name=$matches[1]&feed=$matches[2]

Standard WordPress rule for categories:

[category/(.+?)/feed/(feed|rdf|rss|rss2|atom|some-custom-feed1|some-custom-feed2|…)/?$] => index.php?category_name=$matches[1]&feed=$matches[2]

See in the standard rule how custom feed names are added?

Please fix!

Thank you

Viewing 3 replies - 1 through 3 (of 3 total)

Thread Starter DrLightman
(@drlightman)

7 years, 1 month ago
A fix could be, where you do this:
```
$category_rewrite[ $blog_prefix . '(' . $category_nicename . ')/(?:feed/)?(feed|rdf|rss|rss2|atom)/?$' ] =
 'index.php?category_name=$matches[1]&feed=$matches[2]';
```
Do this instead:
```
$feeds = implode('|', $wp_rewrite->feeds);
$category_rewrite[ $blog_prefix . '(' . $category_nicename . ')/(?:feed/)?(' . $feeds . ')/?$' ] =
 'index.php?category_name=$matches[1]&feed=$matches[2]';
```
Plugin Support amboutwe
(@amboutwe)

7 years, 1 month ago

Can you please submit that to our GitHub repository for Yoast SEO so our development team can investigate it? Thanks!

Thread Starter DrLightman
(@drlightman)

7 years, 1 month ago

Done.

https://github.com/Yoast/wordpress-seo/issues/6750

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘[bug] if removing /category/, rewrite rules will ignore custom feeds’ is closed to new replies.

In: Plugins
3 replies
2 participants
Last reply from: DrLightman
Last activity: 7 years, 1 month ago
Status: resolved