BUG: Dynamic Group Impressions Failing (NaN due to missing admeta[3])
-
Hello,
I am reporting an urgent bug regarding impression tracking for dynamic groups. My ads are rotating successfully and clicks are tracking correctly, but the AJAX post call for impressions never fires due to a mathematical error in the plugin’s JavaScript file jquery.groups.js. Our impressions statistics have dropped dramatically, and we’ve spent hours trying to figure out why.The Issue: The PHP generating the ad HTML is outputting a base64
data-trackstring that decodes to only 3 comma-separated values (e.g.,"NDYsMiwxMA=="decodes to"46,2,10").However, in your JS file (
jquery.groups.js), thegsliderfunction attempts to access a 4th value to calculate the impression timer:Line 65:
var expired = now - admeta[3];Why it fails: Because
admeta[3]isundefined(since the array only goes up to index 2),expiredbecomesNaN. On the next line, the conditionif(session <= expired) {compares a number toNaN. In JavaScript, this always evaluates tofalse, causing the script to completely bypass the$.postAJAX call to track the impression.Could you please review the
admetaarray indexes and issue a patch to fix this mismatch?Thank you!
You must be logged in to reply to this topic.