buddypress issue

  • Resolved nientepopcorn

    (@nientepopcorn)


    6 years, 9 months ago

    There is an issue with profile page and group page of buddypress:
    buddypress write some css rules in these pages, missing after Fast Velocity Minify
    use.
    Thank you

Viewing 11 replies - 1 through 11 (of 11 total)
  • Plugin Author Raul P.

    (@alignak)

    6 years, 9 months ago

    Where does it write the css rules, in the header, body, footer?
    Is it on a file, or on a style tag?

    Please also note that inline css that is a children of a file (https://codex.wordpress.org/Function_Reference/wp_add_inline_style), is merged together by the script.

    Please take a look at the minified file to see if it’s inside.

    Thread Starter nientepopcorn

    (@nientepopcorn)

    6 years, 9 months ago

    Each user has a “cover image”.
    “Cover image” is a background image.
    Cover image css rule is inside tag head.
    Plugin copy “Cover image css rule” inside css minified, so each user has the same “cover image”.

    An example http://www.nientepopcorn.it/members/stefania/

    Plugin Author Raul P.

    (@alignak)

    6 years, 9 months ago

    Thanks.

    Can you please check if adding /bp-legacy/css/buddypress.min.css to the ignore list, fixes that?

    Thread Starter nientepopcorn

    (@nientepopcorn)

    6 years, 9 months ago

    It does not change anything.
    I should be able to exclude (from minification) the element with id “bp-legacy-css-inline-css” to fix.

    <style id='bp-legacy-css-inline-css' type='text/css'>
#buddypress #header-cover-image{
height:225px;
background-image:url(https://www.nientepopcorn.it/wp-content/uploads/buddypress/members/9/cover-image/fca966cd92fb9e1e4ae759dc00ad1547-bp-cover-image.jpg)
...
...
    • This reply was modified 6 years, 9 months ago by nientepopcorn.
    Plugin Author Raul P.

    (@alignak)

    6 years, 9 months ago

    I’ve pushed version 2.1.5 that should solve your issue.
    Please update, purge all caches (plugin status page first, followed by your cache plugin) and give it a try.

    Thanks

    Thread Starter nientepopcorn

    (@nientepopcorn)

    6 years, 9 months ago

    Thank you
    New option work fine.

    There is a new alert:
    “Notice: Undefined variable: data in /var/www/nientepopcorn.it/htdocs/wp-content/plugins/fast-velocity-minify/inc/functions.php on line 730”
    It was not there before.

    I see a big issue that was not there before: my main CSSs are not minimized, they are not considered.
    My css are included by code like this:
    wp_enqueue_style( 'style-default_480', get_template_directory_uri() . '/css/default_480.css' );

    If you update your filehost you can see
    83.96.204.141 http://www.nientepopcorn.it

    (I’m sorry for my english, :))

    • This reply was modified 6 years, 9 months ago by nientepopcorn.
    Thread Starter nientepopcorn

    (@nientepopcorn)

    6 years, 9 months ago

    I understand that it is better to avoid “?20170101”
    wp_enqueue_style( 'style-default_480', get_template_directory_uri() . '/css/default_480.css?20170701' );

    Plugin Author Raul P.

    (@alignak)

    6 years, 9 months ago

    You have to look at the manual:
    https://developer.wordpress.org/reference/functions/wp_enqueue_style/

    If you need a query string, you can do it like this:
    wp_enqueue_style('style-default_480', get_template_directory_uri() . '/css/default_480.css', array(), '20170701', 'all');

    The most important part however, is where you’re enqueuing it.
    It should be inside a function and go on the wp_enqueue_scripts hook.
    https://codex.wordpress.org/Plugin_API/Action_Reference/wp_enqueue_scripts

    —

    The Undefined variable: data is a typo on my plugin, it will be fixed asap.
    However, it only shows if you enabled wp_debug (which should be off on production).

    • This reply was modified 6 years, 9 months ago by Raul P..
    Thread Starter nientepopcorn

    (@nientepopcorn)

    6 years, 9 months ago

    You’re very kind!
    Thank you

    Plugin Author Raul P.

    (@alignak)

    6 years, 9 months ago

    I pushed version 2.1.6 which behaves differently, but it should work fine for you.
    Please test it for the earlier header issue and see it it works (it should).
    Because you have different background images, you will have more files generated (they have to be unique), but since those are static files, not to worry.

    Thread Starter nientepopcorn

    (@nientepopcorn)

    6 years, 9 months ago

    Everything works fine.
    Thank you

Viewing 11 replies - 1 through 11 (of 11 total)
  • The topic ‘buddypress issue’ is closed to new replies.