Hi thanks for the feedback. I’ll try to work on this next week.
Thanks
Hey @viruthagiri,
Thanks mate for considering this. We all are waiting for the update and we do support you for your hardtime.
Kudos!
Hi there,
#2 is not a bug. Its displaying both Received and Sent activity.
Other than that I have fixed #1 and #2
Please download the development copy from here
https://github.com/mistergiri/buddypress-compliments
You need to add these two lines in your theme functions.php file to make #1 and #3 work
add_filter('bp_comp_display_comp_content_in_activity', '__return_true');
add_filter('bp_comp_check_duplicate', '__return_true');
Let me know how that goes.
Thanks
-
This reply was modified 6 years, 6 months ago by
Viruthagiri.
Hey @viruthagiri,
You’re awesome! That definitely works. Thanks a lot for making time and considering my request.
I would like to give some feedback on them.
Here’s new screenshot for #1: New screenshot
- Though it is shows the compliment for received activity, can you make it for sent activity too?
- As you can see in the screenshot, I was able to see the message sent with compliment but not the compliment. How about adding compliment along with message? Maybe? Here’s the compliment page screenshot with “bad profile” compliment.
#3 works perfectly.
Although, for the sake of flexibility, You can add filter to change text for “Duplicate compliment detected.” I was able to change this from core of the plugin but many of the community members won’t be able to do it.
On #2, I know it should display both received and sent activity, but I was talking about a condition here (If both receiver (person A) and sender (person B) are friends with person C, then show either one of the activity.)
It is okay if you want to keep it that way. Just a suggestion.
Thanks a lot for making changes to the plugin. Kudos and we all appreciate your efforts and contribution to the community.
Kudos!
Hi there,
I have pushed the fix to display sent activity.
https://github.com/mistergiri/buddypress-compliments
Yesterday I did try to display the compliment with icon in the activity page itself. But buddypress stripping html from the activity messages.
So I couldn’t able to make it work.
You can see the code here.
https://github.com/mistergiri/buddypress-compliments/blob/master/includes/bp-compliments-activity.php#L336
You can replace this line
https://github.com/mistergiri/buddypress-compliments/blob/master/includes/bp-compliments-activity.php#L347
with
This code
$activity->content = $image.$message;
Since html is stripped off, its not possible to style it. Thats why I display only the message
As for #2, I don’t wanna break existing things. If I modify stuffs in existing thing, then i have to test thoroughly. This is the reason why I have asked you to add code in your theme functions.php file to enable the future you requested. So I’ll keep #2 as it is for now, but i’ll consider this as a low priority bug and try to fix that in future versions.
Thanks
Hey @viruthagiri,
It still looks good. Thanks for the valuable update and contribution. Let’s just keep things as they are right now and I must admit, They are pretty good!.
Once again, Thank you for your time and contribution.