Thread Starter
Touda
(@touda)
BTW: can we safely deactivate the plugin without losing any information or plugin’s options? Or will it all be lost when re-activated?
Update coming shortly.
For the record, you can deactivate the plugin at any time. It will never delete the data — all the data will still be stored in your database.
1.4.19 is pushed to the repository and should resolve this issue.
Thread Starter
Touda
(@touda)
Thanks for your quick answer, Chris. I’ll upgrade the sooner I can.
For the record, you can deactivate the plugin at any time. It will never delete the data — all the data will still be stored in your database.
That includes all the plugin’s options?
Thread Starter
Touda
(@touda)
That did the trick. Thanks, Chris.
Now we only have to re-hack the new version 😉
BTW, you might be interested in our hacks’ code… you could include it in future releases. As you may remember it extended some of its functions… If so, just let me know and I’ll send it to you 🙂
That includes all the plugin’s options?
Yep. I don’t delete the plugin’s options on deactivation.
If you want (I’m not sure what sort of condition they are in) you can submit them as pull requests on the repository on GitHub. I’d be happy to look at them.
https://github.com/jazzsequence/book-review-library/pulls
Thread Starter
Touda
(@touda)
If you want (I’m not sure what sort of condition they are in) you can submit them as pull requests on the repository on GitHub. I’d be happy to look at them.
Thanks, Chris, but I’ve never used GitHub as a developer, so I’m not used to its terminology and practices, and I’m not sure about how to do what you propose 🙁
Basically on GitHub, you would “fork” the original repository and then create a branch with your changes. (If you have a lot of changes you want to have considered individually, you would probably want to create separate branches for each change. Or you can just upload the fully modified code to your fork of the repository.) When GitHub detects changes to the original repository in your copy/fork, it will give you an option to submit a pull request. A pull request alerts the original author that you have something you want them to look at. It includes a diff of all the changes and a note about whether or not it can be merged in. If there is automated testing set up, it will also say whether or not it passes the tests.
This is the easiest way to get your code changes merged in because I don’t have time to spin up a new environment to test your code or to look through the entire modified plugin to see what’s different.
